From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: vagabon.xyz@gmail.com, linux-mips@linux-mips.org
Subject: Re: [PATCH] Fix __copy_{to,from}_user_inatomic
Date: Mon, 19 Feb 2007 18:46:46 +0000 [thread overview]
Message-ID: <20070219184646.GA10820@linux-mips.org> (raw)
In-Reply-To: <20070217.011220.70478485.anemo@mba.ocn.ne.jp>
On Sat, Feb 17, 2007 at 01:12:20AM +0900, Atsushi Nemoto wrote:
> Date: Sat, 17 Feb 2007 01:12:20 +0900 (JST)
> To: vagabon.xyz@gmail.com
> Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
> Subject: Re: [PATCH] Fix __copy_{to,from}_user_inatomic
> From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Content-Type: Text/Plain; charset=us-ascii
>
> On Fri, 16 Feb 2007 16:32:53 +0100, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
> > These functions are aliases to __copy_{to,from}_user resp but they
> > are not allowed to sleep. Therefore might_sleep() must not be used
> > by their implementions.
>
> This changes CONFIG_PREEMPT_VOLUNTARY behavior.
> In this case might_sleep() is not just an annotation.
>
> Well, so currently CONFIG_PREEMPT_VOLUNTARY seems broken. Maybe we
> need separete functions anyway.
The issue needed to be tackled so while suboptimal I've added a chainsawed
version of memcpy to provide __copy_from_user_inatomic. Not elegant but
hopefully that will be cleaned soon. memcpy could use a general ovehaul
anyway.
Ralf
prev parent reply other threads:[~2007-02-19 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 15:32 [PATCH] Fix __copy_{to,from}_user_inatomic Franck Bui-Huu
2007-02-16 15:54 ` Ralf Baechle
2007-02-16 16:06 ` Franck Bui-Huu
2007-02-16 16:12 ` Atsushi Nemoto
2007-02-19 18:46 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070219184646.GA10820@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox