From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [MIPS] Untangle the rest of the prom_printf mess and convert to early printk
Date: Thu, 1 Mar 2007 19:10:19 +0000 [thread overview]
Message-ID: <20070301191019.GA23843@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64N.0703011853230.25556@blysk.ds.pg.gda.pl>
On Thu, Mar 01, 2007 at 06:55:30PM +0000, Maciej W. Rozycki wrote:
> > arch/mips/dec/prom/console.c | 38 +--------
>
> Any particular reason for replacing an optimised version with this
> miserable contraption?
I doubt anybody will notice when the first few lines of bootup messages
take a few cycles extra. For the moment it did matter to get rid of
the impressive barbed wire fence made from several independant early
printk implementations and macros, functions and function pointers being
named prom_printf with no apparent pattern.
If you think the code really needs to be optimized as the next step, I
take patches.
Ralf
prev parent reply other threads:[~2007-03-01 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S20039493AbXCASgj/20070301183639Z+38846@ftp.linux-mips.org>
2007-03-01 18:55 ` [MIPS] Untangle the rest of the prom_printf mess and convert to early printk Maciej W. Rozycki
2007-03-01 19:10 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070301191019.GA23843@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox