From: Ralf Baechle <ralf@linux-mips.org>
To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: mbizon@freebox.fr, linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] Always use virt_to_phys() when translating kernel addresses [take #2]
Date: Mon, 19 Mar 2007 22:28:14 +0000 [thread overview]
Message-ID: <20070319222814.GA16895@linux-mips.org> (raw)
In-Reply-To: <45FEBC1A.8070604@innova-card.com>
On Mon, Mar 19, 2007 at 05:36:42PM +0100, Franck Bui-Huu wrote:
> diff --git a/include/asm-mips/mach-generic/dma-coherence.h b/include/asm-mips/mach-generic/dma-coherence.h
> index 76e04e7..3a2ac54 100644
> --- a/include/asm-mips/mach-generic/dma-coherence.h
> +++ b/include/asm-mips/mach-generic/dma-coherence.h
> @@ -28,6 +28,13 @@ static inline unsigned long plat_dma_addr_to_phys(dma_addr_t dma_addr)
> return dma_addr;
> }
>
> +static inline unsigned long plat_dma_addr_to_virt(dma_addr_t dma_addr)
> +{
> + unsigned long addr = plat_dma_addr_to_phys(dma_addr);
> +
> + return (unsigned long)phys_to_virt(addr);
> +}
> +
Putting this function into include/asm-mips/mach-generic/dma-coherence.h
breaks the build for all machines that don't include this header. I
applied your patch with this issue fixed.
Ralf
prev parent reply other threads:[~2007-03-19 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 9:41 [PATCH] Always use virt_to_phys() when translating kernel addresses Franck Bui-Huu
2007-03-19 16:02 ` Maxime Bizon
2007-03-19 16:16 ` Franck Bui-Huu
2007-03-19 16:36 ` [PATCH] Always use virt_to_phys() when translating kernel addresses [take #2] Franck Bui-Huu
2007-03-19 22:28 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070319222814.GA16895@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox