From: Thiemo Seufer <ths@networkno.de>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Florian Fainelli <florian.fainelli@int-evry.fr>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] Fix a warning in lib-64/dump_tlb.c
Date: Wed, 21 Mar 2007 16:55:21 +0000 [thread overview]
Message-ID: <20070321165521.GI2311@networkno.de> (raw)
In-Reply-To: <Pine.LNX.4.64N.0703211540520.2628@blysk.ds.pg.gda.pl>
Maciej W. Rozycki wrote:
> On Fri, 16 Mar 2007, Florian Fainelli wrote:
>
> > This patch suppresses a warning in arch/mips/lib-64/dump_tlb.c
> >
> > Signed-off-by: Florian Fainelli <florian.fainelli@int-evry.fr>
> >
> > -----
> > diff --git a/arch/mips/lib-64/dump_tlb.c b/arch/mips/lib-64/dump_tlb.c
> > index 8232900..60a87c5 100644
> > --- a/arch/mips/lib-64/dump_tlb.c
> > +++ b/arch/mips/lib-64/dump_tlb.c
> > @@ -30,6 +30,7 @@ static inline const char *msk2str(unsigned int mask)
> > case PM_64M: return "64Mb";
> > case PM_256M: return "256Mb";
> > #endif
> > + default: return NULL;
> > }
> > }
>
> I guess BUG() would be appropriate here.
AFAICS NULL is wrong, it could cause the printk to crash.
Thiemo
next prev parent reply other threads:[~2007-03-21 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 15:40 [PATCH] Fix a warning in lib-64/dump_tlb.c Florian Fainelli
2007-03-21 15:43 ` Maciej W. Rozycki
2007-03-21 16:55 ` Thiemo Seufer [this message]
2007-03-26 21:09 ` Florian Fainelli
2007-03-26 21:16 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321165521.GI2311@networkno.de \
--to=ths@networkno.de \
--cc=florian.fainelli@int-evry.fr \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox