Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Jan Nikitenko <jan.nikitenko@gmail.com>
Cc: spi-devel-general@lists.sourceforge.net, linux-mips@linux-mips.org
Subject: Re: spi: Add support for au1550 spi controller
Date: Fri, 27 Apr 2007 20:04:41 -0700	[thread overview]
Message-ID: <200704272004.42164.david-b@pacbell.net> (raw)
In-Reply-To: <46324403.4080606@gmail.com>

On Friday 27 April 2007, Jan Nikitenko wrote:

> As the spi clock of the controller depends on main input clock that 
> shall be configured externally, platform data structure for au1550 spi 
> controller driver contains mainclk_hz attribute to define the input 
> clock hz ...

I suppose the only reason this isn't more or less just

	mainclk_hz = clk_get_rate(clk_get(hw->dev, "main"));

is that arch/mips/au1000/* doesn't support <linux/clk.h> yet...

In general I think it's much preferable to support that common
infrastructure than invent alternative solutions.  But I won't
be antisocial and try to hold back this driver on _that_ account!

But I will feel free to point out this particular bit of missing
infrastructure.  I hope that supporting it is on the agenda of
the MIPS subset of the embedded Linux world.  :)

- Dave

      reply	other threads:[~2007-04-28  3:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-27 18:42 spi: Add support for au1550 spi controller Jan Nikitenko
2007-04-28  3:04 ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704272004.42164.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=jan.nikitenko@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox