From: Jean Delvare <khali@linux-fr.org>
To: Domen Puncer <domen.puncer@telargo.com>
Cc: Manuel Lauss <mano@roarinelk.homelinux.net>,
i2c@lm-sensors.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] i2c-au1550: convert to platform driver
Date: Fri, 18 May 2007 14:38:39 +0200 [thread overview]
Message-ID: <20070518143839.41117729@hyperion.delvare> (raw)
In-Reply-To: <20070518072427.GC20713@moe.telargo.com>
Hi Domen,
On Fri, 18 May 2007 09:24:27 +0200, Domen Puncer wrote:
> On 17/05/07 12:38 +0200, Jean Delvare wrote:
> > On Wed, 16 May 2007 07:34:40 +0200, Manuel Lauss wrote:
> > > if (!(stat & PSC_SMBSTAT_TE) || !(stat & PSC_SMBSTAT_RE)) {
> > > - sp->psc_smbpcr = PSC_SMBPCR_DC;
> > > + au_writel(PSC_SMBPCR_DC, base + PSC_SMBPCR);
> > > au_sync();
> > > - do {
> > > - stat = sp->psc_smbpcr;
> > > - au_sync();
> > > - } while ((stat & PSC_SMBPCR_DC) != 0);
> > > + while (au_readl(base + PSC_SMBPCR) & PSC_SMBPCR_DC)
> > > + msleep(0);
> >
> > You are changing the behavior here, while this patch is supposed to
> > only convert the driver to the new device driver model.
>
> Well... since msleep(0) is nothing, it's the same, but it does
> look weird.
msleep(0) isn't nothing. It sleeps until the next tick.
--
Jean Delvare
next prev parent reply other threads:[~2007-05-18 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 5:34 [PATCH 2/2] i2c-au1550: convert to platform driver Manuel Lauss
2007-05-17 10:38 ` Jean Delvare
2007-05-18 7:24 ` Domen Puncer
2007-05-18 12:38 ` Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-15 18:09 Manuel Lauss
2007-05-15 18:27 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518143839.41117729@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=domen.puncer@telargo.com \
--cc=i2c@lm-sensors.org \
--cc=linux-mips@linux-mips.org \
--cc=mano@roarinelk.homelinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox