From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Daniel Laird <daniel.j.laird@nxp.com>
Cc: linux-mips@linux-mips.org
Subject: Re: Generating patches and using checkpatch.pl
Date: Thu, 28 Jun 2007 19:45:21 +0200 [thread overview]
Message-ID: <20070628174521.GD27862@lug-owl.de> (raw)
In-Reply-To: <4683C792.4000100@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Thu, 2007-06-28 15:37:06 +0100, Daniel Laird <daniel.j.laird@nxp.com> wrote:
> I ran checkpatch.pl as Ralf suggested before.
[...]
> - Line over 80 chars
> - printk must have KERN_ debug level
> - must have a space after this (, or *)
> - use tabs not spaces
> - Do not use C99 comments.
> To name but a few
>
> My question is:
> If you do a patch and find all these errors is it expected that I fix
> all these problems, or I just make sure my changes do not make it worse!
General rules of thumb:
* Keep the coding style of the file if you're only doing minor
patching. Don't introduce leading whitespace, leading tabs before
spaces. Maybe keep the comment and indention style.
* If it's more like a rewrite, fix it entirely.
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Gib Dein Bestes. Dann übertriff Dich selbst!
the second :
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2007-06-28 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 14:37 Generating patches and using checkpatch.pl Daniel Laird
2007-06-28 17:45 ` Jan-Benedict Glaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070628174521.GD27862@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=daniel.j.laird@nxp.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox