From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 12 Jul 2007 21:14:58 +0100 (BST) Received: from mail.onstor.com ([66.201.51.107]:970 "EHLO mail.onstor.com") by ftp.linux-mips.org with ESMTP id S20022733AbXGLUO4 (ORCPT ); Thu, 12 Jul 2007 21:14:56 +0100 Received: from onstor-exch02.onstor.net ([66.201.51.106]) by mail.onstor.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 12 Jul 2007 13:14:48 -0700 Received: from ripper.onstor.net ([10.0.0.42]) by onstor-exch02.onstor.net with Microsoft SMTPSVC(6.0.3790.1830); Thu, 12 Jul 2007 13:14:48 -0700 Date: Thu, 12 Jul 2007 13:14:48 -0700 From: Andrew Sharp To: Andrew Morton Cc: Mark Mason , Andy Whitcroft , Randy Dunlap , Joel Schopp , linux-mips@linux-mips.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support Message-ID: <20070712131448.0175e2cc@ripper.onstor.net> In-Reply-To: <20070712114712.de5d6c9d.akpm@linux-foundation.org> References: <20070712114712.de5d6c9d.akpm@linux-foundation.org> Organization: Onstor X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 12 Jul 2007 20:14:48.0437 (UTC) FILETIME=[4BE4DA50:01C7C4C1] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 15758 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: andy.sharp@onstor.com Precedence: bulk X-list: linux-mips On Thu, 12 Jul 2007 11:47:12 -0700 Andrew Morton wrote: > On Thu, 12 Jul 2007 18:39:00 +0100 (BST) > "Maciej W. Rozycki" wrote: > > > This is a driver for the SB1250 DUART, a dual serial port > > implementation included in the Broadcom family of SOCs descending > > from the SiByte SB1250 MIPS64 chip multiprocessor. It is a new > > implementation replacing the old-fashioned driver currently present > > in the linux-mips.org tree. It supports all the usual features one > > would expect from a(n asynchronous) serial driver, including modem > > line control (as far as hardware supports it -- there is edge > > detection logic missing from the DCD and RI lines and the driver > > does not implement polling of these lines at the moment), the > > serial console, BREAK transmission and reception, including the > > magic SysRq. The receive FIFO threshold is not maintained though. > > > > ... > > > > + > > +#if defined(CONFIG_SIBYTE_BCM1x55) || > > defined(CONFIG_SIBYTE_BCM1x80) +#include > > +#include > > + > > +#define SBD_CHANREGS(line) A_BCM1480_DUART_CHANREG((line), > > 0) +#define SBD_CTRLREGS(line) > > A_BCM1480_DUART_CTRLREG((line), 0) +#define > > SBD_INT(line) (K_BCM1480_INT_UART_0 + (line)) + > > +#elif defined(CONFIG_SIBYTE_SB1250) || > > defined(CONFIG_SIBYTE_BCM112X) +#include > > +#include > > + > > +#define SBD_CHANREGS(line) A_DUART_CHANREG((line), 0) > > +#define SBD_CTRLREGS(line) A_DUART_CTRLREG(0) > > +#define SBD_INT(line) (K_INT_UART_0 + (line)) > > + > > +#else > > +#error invalid SB1250 UART configuration > > + > > +#endif > > If the #error can trigger, the Kconfig is broken, yes? (No action is > required though - it's always good to have checks) > > > +#define to_sport(uport) container_of(uport, struct sbd_port, port) > > That didn't need to be implemented as a macro. > > > +#define __unused __attribute__((__unused__)) > > Please use the generic implementations here. `grep unused > include/linux/compiler*.h'. > > > +/* > > + * In bug 1956, we get glitches that can mess up uart registers. > > This > > + * "read-mode-reg after any register access" is an accepted > > workaround. > > + */ > > > > > > Perhaps a reference to where that bug number came from? It's a Sibyte errata/WAR number as I recall. > > +static void __war_sbd1956(struct sbd_port *sport) > > +{ > > + __read_sbdchn(sport, R_DUART_MODE_REG_1); > > + __read_sbdchn(sport, R_DUART_MODE_REG_2); > > +} > > > > ... > > > > +static struct uart_ops sbd_ops = { > > I suppose if we made this const, something would blow up. > > > > > There is no power management support in this driver. >