From: "Steven J. Hill" <sjhill@realitydiluted.com>
To: Songmao Tian <tiansm@lemote.com>
Cc: linux-mips@linux-mips.org
Subject: Re: Add errno definition to pm.h
Date: Mon, 30 Jul 2007 10:45:52 -0500 [thread overview]
Message-ID: <20070730154552.GA4937@real.realitydiluted.com> (raw)
In-Reply-To: <46AE05DE.1020109@lemote.com>
On Mon, Jul 30, 2007 at 11:38:06PM +0800, Songmao Tian wrote:
> commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
> static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
> which need errno definition
>
> Signed-off-by: Songmao Tian <tiansm@lemote.com>
>
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index e52f6f8..48b71ba 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -25,6 +25,7 @@
>
> #include <linux/list.h>
> #include <asm/atomic.h>
> +#include <asm/errno.h>
>
You should be including <linux/errno.h> which then includes the
architecture-specific file. This patch should be rejected.
-Steve
next prev parent reply other threads:[~2007-07-30 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 15:38 Add errno definition to pm.h Songmao Tian
2007-07-30 15:45 ` Steven J. Hill [this message]
2007-07-31 0:46 ` Songmao Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730154552.GA4937@real.realitydiluted.com \
--to=sjhill@realitydiluted.com \
--cc=linux-mips@linux-mips.org \
--cc=tiansm@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox