From: John Levon <levon@movementarian.org>
To: Dajie Tan <jiankemeng@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>,
oprofile-list@lists.sourceforge.net
Subject: Re: [PATCH][resend] add support for profiling loongson2e
Date: Wed, 1 Aug 2007 13:38:40 +0100 [thread overview]
Message-ID: <20070801123840.GA29950@totally.trollied.org.uk> (raw)
In-Reply-To: <20070801130109.GA5170@sw-linux.com>
On Wed, Aug 01, 2007 at 05:01:09PM +0400, Dajie Tan wrote:
> diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c
> index a83c3db..fde9819 100644
> --- a/drivers/oprofile/cpu_buffer.c
> +++ b/drivers/oprofile/cpu_buffer.c
> @@ -148,6 +148,10 @@ add_sample(struct oprofile_cpu_buffer * cpu_buf,
> unsigned long pc, unsigned long event)
> {
> struct op_sample * entry = &cpu_buf->buffer[cpu_buf->head_pos];
> +
> + if(!entry)
> + return;
> +
Perhaps I wasn't clear. This change is unacceptable and must not be
merged.
john
prev parent reply other threads:[~2007-08-01 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 13:01 [PATCH][resend] add support for profiling loongson2e Dajie Tan
2007-08-01 12:38 ` John Levon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070801123840.GA29950@totally.trollied.org.uk \
--to=levon@movementarian.org \
--cc=jiankemeng@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox