Re: [PATCH 1/7] AR7: core support

[Thiemo Seufer <ths@networkno.de>]

Matteo Croce wrote:
[snip]
> diff --git a/arch/mips/ar7/clock.c b/arch/mips/ar7/clock.c
> new file mode 100644
> index 0000000..9edde34
> --- /dev/null
> +++ b/arch/mips/ar7/clock.c
> @@ -0,0 +1,472 @@
> +/*
> + * $Id: clock.c 8036 2007-07-18 13:42:24Z florian $

No CVS id strings, please.

> + * Copyright (C) 2007 OpenWrt.org

Does OpenWRT actually require copyright assignment? If not, this place
should list the Author(s) as the actual copyright holders.

[snip]
> +int ar7_afe_clock = 35328000;
> +int ar7_ref_clock = 25000000;
> +int ar7_xtal_clock = 24000000;
> +
> +int ar7_cpu_clock = 150000000;
> +EXPORT_SYMBOL(ar7_cpu_clock);
> +int ar7_bus_clock = 125000000;

Magic constants.

[snip]
> +EXPORT_SYMBOL(ar7_bus_clock);
> +int ar7_dsp_clock = 0;
> +EXPORT_SYMBOL(ar7_dsp_clock);
> +
> +static int gcd(int x, int y)
> +{
> +	if (x > y)
> +		return (x % y) ? gcd(y, x % y) : y;
> +	return (y % x) ? gcd(x, y % x) : x;
> +}
> +
> +static inline int ABS(int x)
> +{
> +	return (x >= 0) ? x : -x;
> +}

Isn't that already available in the generic kernel code?


Thiemo