From: Ralf Baechle <ralf@linux-mips.org>
To: Maxime Bizon <mbizon@freebox.fr>
Cc: linux-mips@linux-mips.org
Subject: Re: Suspicious test in dma-default.c
Date: Tue, 4 Sep 2007 15:04:50 +0100 [thread overview]
Message-ID: <20070904140450.GA5624@linux-mips.org> (raw)
In-Reply-To: <1188550994.29619.10.camel@sakura.staff.proxad.net>
On Fri, Aug 31, 2007 at 11:03:14AM +0200, Maxime Bizon wrote:
> I don't know exactly why cpu_is_noncoherent_r10000() is needed, but the
> test looks wrong:
>
> return !plat_device_is_coherent(dev) &&
> (current_cpu_data.cputype == CPU_R10000 &&
> current_cpu_data.cputype == CPU_R12000);
I guess a processor need to be quite shizophrenic to pass this test ;-)
Patch applied, thanks.
Ralf
prev parent reply other threads:[~2007-09-04 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 9:03 Suspicious test in dma-default.c Maxime Bizon
2007-09-04 14:04 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070904140450.GA5624@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox