From: Thiemo Seufer <ths@networkno.de>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: bo y <byu1000@gmail.com>, linux-mips <linux-mips@linux-mips.org>,
ralf@linux-mips.org
Subject: Re: tlbex.c
Date: Wed, 5 Sep 2007 12:11:22 +0100 [thread overview]
Message-ID: <20070905111121.GC9977@networkno.de> (raw)
In-Reply-To: <Pine.LNX.4.64N.0708291302350.26167@blysk.ds.pg.gda.pl>
Maciej W. Rozycki wrote:
> On Mon, 27 Aug 2007, bo y wrote:
>
> > Should the following instruction field masks to be 0x3f ?
> >
> > #define OP_MASK 0x2f
> > #define FUNC_MASK 0x2f
> >
> > I do not see OP_MASK is used but FUNC_MASK is used in the same file.
>
> Yes. Send a patch.
Appended, please apply.
Thiemo
Signed-Off-By: Thiemo Seufer <ths@networkno.de>
diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
index 4ec0964..9cb3964 100644
--- a/arch/mips/mm/tlbex.c
+++ b/arch/mips/mm/tlbex.c
@@ -78,7 +78,7 @@ enum fields
SET = 0x200
};
-#define OP_MASK 0x2f
+#define OP_MASK 0x3f
#define OP_SH 26
#define RS_MASK 0x1f
#define RS_SH 21
@@ -92,7 +92,7 @@ enum fields
#define IMM_SH 0
#define JIMM_MASK 0x3ffffff
#define JIMM_SH 0
-#define FUNC_MASK 0x2f
+#define FUNC_MASK 0x3f
#define FUNC_SH 0
#define SET_MASK 0x7
#define SET_SH 0
next prev parent reply other threads:[~2007-09-05 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 15:22 tlbex.c bo y
2007-08-29 12:04 ` tlbex.c Maciej W. Rozycki
2007-09-05 11:11 ` Thiemo Seufer [this message]
2007-09-05 12:13 ` tlbex.c Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070905111121.GC9977@networkno.de \
--to=ths@networkno.de \
--cc=byu1000@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox