From: Ralf Baechle <ralf@linux-mips.org>
To: linux-mips@linux-mips.org
Subject: [tglx@linutronix.de: [PATCH] clockevents: fix bogus next_event reset for oneshot broadcast devices]
Date: Thu, 27 Sep 2007 23:19:56 +0100 [thread overview]
Message-ID: <20070927221956.GA19990@linux-mips.org> (raw)
----- Forwarded message from Thomas Gleixner <tglx@linutronix.de> -----
From: Thomas Gleixner <tglx@linutronix.de>
Date: Fri, 28 Sep 2007 00:17:04 +0200
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] clockevents: fix bogus next_event reset for oneshot
broadcast devices
Content-Type: text/plain
In periodic broadcast mode the next_event member of the broadcast device
structure is set to KTIME_MAX in the interrupt handler. This is wrong,
as we calculate the next periodic interrupt with this variable.
Remove it.
Noticed by Ralf. MIPS is the first user of this mode, it does not affect
existing users.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-and-tested-by: Ralf Baechle <ralf@linux-mips.org>
---
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index 0962e05..acf15b4 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -176,8 +176,6 @@ static void tick_do_periodic_broadcast(void)
*/
static void tick_handle_periodic_broadcast(struct clock_event_device *dev)
{
- dev->next_event.tv64 = KTIME_MAX;
-
tick_do_periodic_broadcast();
/*
----- End forwarded message -----
Ralf
next reply other threads:[~2007-09-27 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 22:19 Ralf Baechle [this message]
2007-09-28 12:47 ` [tglx@linutronix.de: [PATCH] clockevents: fix bogus next_event reset for oneshot broadcast devices] Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927221956.GA19990@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox