Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: linux-mips@linux-mips.org
Subject: MIPS Makefile not picking up CROSS_COMPILE from environment setting
Date: Thu, 18 Oct 2007 20:46:36 +0200	[thread overview]
Message-ID: <20071018184636.48637242E9@gemini.denx.de> (raw)

Hello,

I noticed that, unlike for other architectures like ARM  or  PowerPC,
the  MIPS Makefile does not pick up the settings from a CROSS_COMPILE
environment variable, at least not with many (all?) default  configu-
rations.

This makes no sense to me - is there an intention behind it?

Or should I submit a patch  to  use  an  environment  setting  if  it
exists, i. e. somthing like this:

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 08355eb..caa04a0 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -43,7 +43,7 @@ UTS_MACHINE		:= mips64
 endif
 
 ifdef CONFIG_CROSSCOMPILE
-CROSS_COMPILE		:= $(tool-prefix)
+CROSS_COMPILE		?= $(tool-prefix)
 endif
 
 ifdef CONFIG_32BIT



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The explanation requiring the fewest assumptions is the  most  likely
to be correct.                                    -- William of Occam

             reply	other threads:[~2007-10-18 18:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-18 18:46 Wolfgang Denk [this message]
2007-10-19  2:47 ` MIPS Makefile not picking up CROSS_COMPILE from environment setting Atsushi Nemoto
2007-10-19  7:16 ` Geert Uytterhoeven
2007-10-21  8:37   ` Geert Uytterhoeven
2007-10-22 13:21     ` Ralf Baechle
2007-10-22 14:30       ` Geert Uytterhoeven
2007-10-19 11:18 ` Ralf Baechle
2007-10-19 12:39   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071018184636.48637242E9@gemini.denx.de \
    --to=wd@denx.de \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox