From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: [MIPS] irq_cpu: use handle_percpu_irq handler to avoid dropping interrupts.
Date: Thu, 22 Nov 2007 17:23:41 +0000 [thread overview]
Message-ID: <20071122172341.GA6973@linux-mips.org> (raw)
In-Reply-To: <20071122161935.GA6605@linux-mips.org>
On Thu, Nov 22, 2007 at 04:19:35PM +0000, Ralf Baechle wrote:
> > This might broke probe_irq_on()/probe_irq_off(), since
> > handle_percpu_irq() does not check IRQ_WAITING bit.
>
> Ok - but does that matter at all? IRQ probing is only used with ISA
> drivers and for those there will be another interrupt controller such as
> a i8259 PIC daisy chained to one of the CPU interrupt pins.
Ah, I think I now understand the problem.
Seems like no interrupt should ever use IRQ_NOPROBE except ISA interrupts
but unfortunately that flag is not everywhere where it should. Maybe the
logic should even be negated and the flag become IRQ_PROBE ...
Ralf
next prev parent reply other threads:[~2007-11-22 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S20032632AbXKOURg/20071115201736Z+24020@ftp.linux-mips.org>
2007-11-22 15:41 ` [MIPS] irq_cpu: use handle_percpu_irq handler to avoid dropping interrupts Atsushi Nemoto
2007-11-22 16:19 ` Ralf Baechle
2007-11-22 17:23 ` Ralf Baechle [this message]
2007-11-22 18:43 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071122172341.GA6973@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox