Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] IP28 support
Date: Wed, 28 Nov 2007 14:34:59 +0000	[thread overview]
Message-ID: <20071128143459.GA22943@linux-mips.org> (raw)
In-Reply-To: <20071126224004.D885AC2B26@solo.franken.de>

On Mon, Nov 26, 2007 at 11:40:04PM +0100, Thomas Bogendoerfer wrote:

> Add support for SGI IP28 machines (Indigo 2 with R10k CPUs)
> This work is mainly based on Peter Fuersts work.
> 
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

Wonderful, this is all looking quite sane now.

 drivers/char/Kconfig                               |    2 
 drivers/input/serio/i8042.h                        |    2 
 drivers/net/Kconfig                                |    2 
 drivers/scsi/Kconfig                               |    2 
 drivers/serial/Kconfig                             |    8 
 drivers/watchdog/Kconfig                           |    2 
 fs/partitions/Kconfig                              |    2 

As just discussed on IRC this all should go via the respective maintainers
or where none is available via akpm + lkml.

> diff --git a/include/asm-mips/dma.h b/include/asm-mips/dma.h
> index 833437d..80caf6b 100644
> --- a/include/asm-mips/dma.h
> +++ b/include/asm-mips/dma.h
> @@ -88,6 +88,9 @@
>  /* Horrible hack to have a correct DMA window on IP22 */
>  #include <asm/sgi/mc.h>
>  #define MAX_DMA_ADDRESS		(PAGE_OFFSET + SGIMC_SEG0_BADDR + 0x01000000)
> +#elif defined(CONFIG_SGI_IP28)
> +#include <asm/sgi/mc.h>
> +#define MAX_DMA_ADDRESS		(PAGE_OFFSET + SGIMC_SEG1_BADDR + 0x01000000)
>  #else
>  #define MAX_DMA_ADDRESS		(PAGE_OFFSET + 0x01000000)
>  #endif

I've always been wondering if the even the IP22 segment was correct at
all.  Afair nobody ever had (E)ISA DMA working on Indigo 2 so that code
is a shot into the dark.  Of course for now it's the sanest thing to
assume that IP28 is the same as the "classic" Indigo 2.

  Ralf

  parent reply	other threads:[~2007-11-28 14:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 22:40 [PATCH] IP28 support Thomas Bogendoerfer
2007-11-28  1:33 ` peter fuerst
2007-11-29 10:01   ` Thomas Bogendoerfer
2007-11-28 14:34 ` Ralf Baechle [this message]
2007-11-29  9:58   ` Thomas Bogendoerfer
2007-11-29 12:15     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071128143459.GA22943@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox