From: Ralf Baechle <ralf@linux-mips.org>
To: Thomas Koeller <thomas.koeller@baslerweb.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 1/4] Introduced GPI_RM9000 configuration parameter
Date: Tue, 18 Dec 2007 11:52:54 +0100 [thread overview]
Message-ID: <20071218105254.GA13344@linux-mips.org> (raw)
In-Reply-To: <20071218003140.4415847A63@mail.koeller.dyndns.org>
On Tue, Dec 18, 2007 at 01:26:19AM +0100, Thomas Koeller wrote:
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index c6fc405..62bc553 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -856,6 +856,9 @@ config GENERIC_ISA_DMA_SUPPORT_BROKEN
> config GENERIC_GPIO
> bool
>
> +config GPI_RM9000
> + bool
> +
> #
> # Endianess selection. Sufficiently obscure so many users don't know what to
> # answer,so we try hard to limit the available choices. Also the use of a
> @@ -927,6 +930,7 @@ config MIPS_TX3927
> config MIPS_RM9122
> bool
> select SERIAL_RM9000
> + select GPI_RM9000
See my earlier reply to http://www.linux-mips.org/cgi-bin/mesg.cgi?a=linux-mips&i=20070911122005.GC24679%40linux-mips.org
Technically the patch is ok but please only introduce new config symbols
only together with an actual user.
Ralf
prev parent reply other threads:[~2007-12-18 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 0:26 [PATCH 1/4] Introduced GPI_RM9000 configuration parameter Thomas Koeller
2007-12-18 10:52 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218105254.GA13344@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=thomas.koeller@baslerweb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox