From: Ralf Baechle <ralf@linux-mips.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Alon Bar-Lev <alon.barlev@gmail.com>,
linux-mips@ftp.linux-mips.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)
Date: Tue, 25 Dec 2007 15:32:41 +0100 [thread overview]
Message-ID: <20071225143240.GA29231@linux-mips.org> (raw)
In-Reply-To: <4770DE51.5000205@ru.mvista.com>
On Tue, Dec 25, 2007 at 01:41:21PM +0300, Sergei Shtylyov wrote:
>> When I have:
>> CONFIG_MIPS_DB1550
>> CONFIG_SOC_AU1550
>> CONFIG_SOC_AU1X00
>> CONFIG_PM
>
>> MEM_SDREFCFG is used at:
>> arch/mips/au1000/common/power.c::pm_do_freq()
>
> PM code is generally broken and unmaintained, so no wonder. I don't
> remember if anyone has fixed CPU context restoration code (it uses a
> "skewed" stack frame).
>
>> While the MEM_SDREFCFG constant is declare only for CONFIG_SOC_AU1000,
>> CONFIG_SOC_AU1500, CONFIG_SOC_AU1100 at:
>> include/asm-mips/mach-au1x00/au1000.h
>
>> Maybe MEM_SDREFCFG should be defined for CONFIG_SOC_AU1X00?
>
> I've just looked into the Au1550 datasheet and indeed it doesn't have
> such register; its SDDRAM controller is not compatible with older SoCs.
>
>> Or there should be #ifdef for its usage in power.c?
>
> Looks like you'll have to invent something... ;-)
>
>> Best Regards,
>> Alon Bar-Lev.
So I guess it's time to mark the whole PM stuff as BROKEN?
Ralf
next prev parent reply other threads:[~2007-12-25 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-23 15:33 [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail) Alon Bar-Lev
2007-12-23 18:22 ` Alon Bar-Lev
2007-12-25 10:41 ` Sergei Shtylyov
2007-12-25 14:32 ` Ralf Baechle [this message]
2007-12-25 17:04 ` Alon Bar-Lev
2007-12-25 17:18 ` Sergei Shtylyov
2007-12-25 17:35 ` Alon Bar-Lev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071225143240.GA29231@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alon.barlev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@ftp.linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox