From: Freddy Spierenburg <freddy@dusktilldawn.nl>
To: Antonino Daplas <adaplas@gmail.com>, source@embeddedalley.com
Cc: linux-mips@linux-mips.org
Subject: [PATCH] Fixes small option parsing bug in au1100fb.c.
Date: Tue, 8 Jan 2008 12:39:45 +0100 [thread overview]
Message-ID: <20080108113944.GG31548@dusktilldawn.nl> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 758 bytes --]
Hi,
I've noticed that drivers/video/au1100fb.c contains a small time
option parsing bug. In the middle of an if...else if...
construction was inserted a lonesome if on it's own. This is
causing an incorrect 'unsupported option' warning, while the
option itself is parsed successfully.
This patch makes the lonesome if part of the whole if...else
if... construction, like it should be. No longer the incorrect
warning message will be displayed.
Signed-off-by: Freddy Spierenburg <freddy@dusktilldawn.nl>
--
$ cat ~/.signature
Freddy Spierenburg <freddy@dusktilldawn.nl> http://freddy.snarl.nl/
GnuPG: 0x7941D1E1=C948 5851 26D2 FA5C 39F1 E588 6F17 FD5D 7941 D1E1
$ # Please read http://www.ietf.org/rfc/rfc2015.txt before complain!
[-- Attachment #1.2: au1100fb.c-patch --]
[-- Type: text/plain, Size: 539 bytes --]
diff -Naur linux-2.6.23-orig/drivers/video/au1100fb.c linux-2.6.23/drivers/video/au1100fb.c
--- linux-2.6.23-orig/drivers/video/au1100fb.c 2008-01-08 11:07:13.000000000 +0000
+++ linux-2.6.23/drivers/video/au1100fb.c 2008-01-08 11:13:37.000000000 +0000
@@ -707,7 +707,8 @@
print_warn("Panel %s not supported!", this_opt);
}
}
- if (!strncmp(this_opt, "nocursor", 8)) {
+ /* No cursor option */
+ else if (!strncmp(this_opt, "nocursor", 8)) {
this_opt += 8;
nocursor = 1;
print_info("Cursor disabled");
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2008-01-08 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 11:39 Freddy Spierenburg [this message]
2008-08-12 8:42 ` [PATCH] Fixes small option parsing bug in au1100fb.c Freddy Spierenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108113944.GG31548@dusktilldawn.nl \
--to=freddy@dusktilldawn.nl \
--cc=adaplas@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=source@embeddedalley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox