From: Ralf Baechle <ralf@linux-mips.org>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: pnx8xxx: move to clocksource
Date: Thu, 10 Jan 2008 14:37:18 +0000 [thread overview]
Message-ID: <20080110143718.GA13489@linux-mips.org> (raw)
In-Reply-To: <4786273D.7010006@gmail.com>
On Thu, Jan 10, 2008 at 05:10:05PM +0300, Vitaly Wool wrote:
> This patch converts PNX8XXX system timer to clocksource.
Checkpatch had a little to moan on your patch:
$ scripts/checkpatch.pl /tmp/pend
ERROR: use tabs not spaces
#79: FILE: arch/mips/philips/pnx8550/common/time.c:57:
+ struct clock_event_device *c = dev_id;$
ERROR: use tabs not spaces
#81: FILE: arch/mips/philips/pnx8550/common/time.c:59:
+ /* clear MATCH, signal the event */$
ERROR: use tabs not spaces
#82: FILE: arch/mips/philips/pnx8550/common/time.c:60:
+ c->event_handler(c);$
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
I fixed those, applied. Thanks!
Ralf
next prev parent reply other threads:[~2008-01-10 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 14:10 pnx8xxx: move to clocksource Vitaly Wool
2008-01-10 14:37 ` Ralf Baechle [this message]
2008-01-10 16:21 ` Sergei Shtylyov
2008-01-10 16:27 ` Ralf Baechle
2008-01-10 16:48 ` Vitaly Wool
2008-01-10 21:50 ` Ralf Baechle
2008-01-10 17:05 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110143718.GA13489@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox