From: Ralf Baechle <ralf@linux-mips.org>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Andreas Schwab <schwab@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
linux-mips@linux-mips.org
Subject: Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles
Date: Fri, 11 Jan 2008 14:17:54 +0000 [thread overview]
Message-ID: <20080111141754.GC19900@linux-mips.org> (raw)
In-Reply-To: <20080102062135.GE2493@hacking>
On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote:
> >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)?
> >It would be better to use $(LINUXINCLUDE) as we then pull in all config
> >symbols too and do not have to hardcode kbuild internal names (include2).
>
> OK. Refine this patch.
LDSCRIPT also needed fixing to get builds in a separate object directory
working again.
I've applied below fix.
Ralf
next prev parent reply other threads:[~2008-01-11 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080101071311.GA2496@hacking>
2008-01-01 7:22 ` [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles WANG Cong
2008-01-01 10:15 ` Sam Ravnborg
2008-01-01 13:11 ` (Try #2) " WANG Cong
2008-01-01 13:44 ` Andreas Schwab
2008-01-01 17:57 ` Sam Ravnborg
2008-01-02 6:21 ` (Try #3) " WANG Cong
2008-01-02 19:24 ` Sam Ravnborg
2008-01-11 14:17 ` Ralf Baechle [this message]
2008-01-11 17:02 ` Sam Ravnborg
2008-01-14 6:26 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080111141754.GC19900@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@osdl.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=sam@ravnborg.org \
--cc=schwab@suse.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox