From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 18 Feb 2008 12:23:15 +0000 (GMT) Received: from elvis.franken.de ([193.175.24.41]:6107 "EHLO elvis.franken.de") by ftp.linux-mips.org with ESMTP id S20036202AbYBRMXM (ORCPT ); Mon, 18 Feb 2008 12:23:12 +0000 Received: from uucp (helo=solo.franken.de) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1JR51a-0003Je-00; Mon, 18 Feb 2008 13:23:10 +0100 Received: by solo.franken.de (Postfix, from userid 1000) id 42D17C2AE1; Mon, 18 Feb 2008 13:18:08 +0100 (CET) Date: Mon, 18 Feb 2008 13:18:08 +0100 To: Adrian Bunk Cc: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [2.6.25 patch] mips: fix SNI_RM EISA=n compilation Message-ID: <20080218121807.GA13080@alpha.franken.de> References: <20080217215948.GL1403@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080217215948.GL1403@cs181133002.pp.htv.fi> User-Agent: Mutt/1.5.13 (2006-08-11) From: tsbogend@alpha.franken.de (Thomas Bogendoerfer) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 18251 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: tsbogend@alpha.franken.de Precedence: bulk X-list: linux-mips On Sun, Feb 17, 2008 at 11:59:48PM +0200, Adrian Bunk wrote: > This patch fixes the following build error with CONFIG_EISA=n caused by > commit 231a35d37293ab88d325a9cb94e5474c156282c0: > > <-- snip --> > > ... > LD .tmp_vmlinux1 > arch/mips/sni/built-in.o: In function `snirm_a20r_setup_devinit': > a20r.c:(.init.text+0x42c): undefined reference to `sni_eisa_root_init' > a20r.c:(.init.text+0x42c): relocation truncated to fit: R_MIPS_26 against `sni_eisa_root_init' > arch/mips/sni/built-in.o: In function `snirm_setup_devinit': > rm200.c:(.init.text+0x52c): undefined reference to `sni_eisa_root_init' > rm200.c:(.init.text+0x52c): relocation truncated to fit: R_MIPS_26 against `sni_eisa_root_init' > make[1]: *** [.tmp_vmlinux1] Error 1 > > <-- snip --> > > Signed-off-by: Adrian Bunk Thanks for your fix, Adrian. Ralf, please apply. Acked-by: Thomas Bogendoerfer > > --- > f6a6c34454cbe463e2d8d567d9e0659161a82a72 diff --git a/include/asm-mips/sni.h b/include/asm-mips/sni.h > index e716447..8c1eb02 100644 > --- a/include/asm-mips/sni.h > +++ b/include/asm-mips/sni.h > @@ -228,7 +228,14 @@ extern void sni_pcimt_irq_init(void); > extern void sni_cpu_time_init(void); > > /* eisa init for RM200/400 */ > +#ifdef CONFIG_EISA > extern int sni_eisa_root_init(void); > +#else > +static inline int sni_eisa_root_init(void) > +{ > + return 0; > +} > +#endif > > /* common irq stuff */ > extern void (*sni_hwint)(void); -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ]