From: Ralf Baechle <ralf@linux-mips.org>
To: Daniel Laird <daniel.j.laird@nxp.com>
Cc: linux-mips@linux-mips.org
Subject: Re: Move arch/mips/philips to arch/mips/nxp
Date: Thu, 28 Feb 2008 09:42:40 +0000 [thread overview]
Message-ID: <20080228094240.GD2750@linux-mips.org> (raw)
In-Reply-To: <64660ef00802270250sae0cd4of9512f13f400dfc6@mail.gmail.com>
On Wed, Feb 27, 2008 at 10:50:53AM +0000, Daniel Laird wrote:
> This patch moves arch/mips/philips to arch/mips/nxp
> It also modifies a couple of places from Philips -> nxp for more consistancy.
>
> This is in preparation for a new set of chip patches coming soon.
>
> The patch has no other work in in it is primarily a move of current
> code to a new location.
> Have run checkpatch.pl and there are many problems with the patch.
> However none of these are new and are already existing issues in the code base.
> A new patch (to be posted later) will clean up some of these as well.
That's fine. It's actually prefered to post large scale code movments
and functional changes or other cleanups as separate changes. Otherwise
it's hard to spot the functional changes in the amalgated mega-patch.
I didn't apply the patch though because several segments of it reject
when applied to top of the latest tree. The patch headers suggest you
did create the patch against 2.6.24.2. With a diff of 48MB between
2.6.24.2 and head of tree such a patch is bound to fail. Anyway, can
you respin the patch against head?
Other nits - please include a Signed-off-by: header, see
Documentation/SubmittingPatches for what it means. And unless your
mail client does things such as breaking long lines or converting tabs to
spaces please send patches inline.
The usual pointer here: http://www.linux-mips.org/wiki/The_perfect_patch
Ralf
next prev parent reply other threads:[~2008-02-28 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 10:50 Move arch/mips/philips to arch/mips/nxp Daniel Laird
2008-02-28 9:42 ` Ralf Baechle [this message]
2008-02-28 16:00 ` M. Warner Losh
2008-02-28 16:10 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228094240.GD2750@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=daniel.j.laird@nxp.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox