From: Ralf Baechle <ralf@linux-mips.org>
To: Daniel Laird <daniel.j.laird@nxp.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH: linux-mips 2.6.24.2]: Move arch/mips/philips to arch/mips/nxp
Date: Thu, 28 Feb 2008 09:58:56 +0000 [thread overview]
Message-ID: <20080228095856.GE2750@linux-mips.org> (raw)
In-Reply-To: <64660ef00802270316s7164fcf6x5baf67c48029b730@mail.gmail.com>
On Wed, Feb 27, 2008 at 11:16:50AM +0000, Daniel Laird wrote:
I was looking through my mail in chronological order so I noticed the older
revision of your patch first.
So your mail client scambles inline patches:
Applying patch patches/0004-01.patch
patching file arch/mips/Kconfig
Hunk #1 succeeded at 309 (offset -3 lines).
patching file arch/mips/kernel/cpu-probe.c
Hunk #1 succeeded at 780 (offset 9 lines).
Hunk #3 succeeded at 889 (offset 11 lines).
patching file arch/mips/Makefile
Hunk #1 succeeded at 408 (offset -2 lines).
patching file arch/mips/nxp/pnx8550/common/gdb_hook.c
patch: **** malformed patch at line 273: IP3106_UART_FIFO_TXFIFO) >> 16) >= 16)
Some clients can be convinced to be nice to inline patches. I've
collected some advice at http://www.linux-mips.org/wiki/Mailing-patches.
If _everything_ else fails, use attachments.
> Signed-off-by: daniel.j.laird <daniel.j.laird@nxp.com>
Yep :-)
Ralf
prev parent reply other threads:[~2008-02-28 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 11:16 [PATCH: linux-mips 2.6.24.2]: Move arch/mips/philips to arch/mips/nxp Daniel Laird
2008-02-28 9:58 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228095856.GE2750@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=daniel.j.laird@nxp.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox