From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 13 Mar 2008 09:04:57 +0000 (GMT) Received: from elvis.franken.de ([193.175.24.41]:62950 "EHLO elvis.franken.de") by ftp.linux-mips.org with ESMTP id S28581691AbYCMJEz (ORCPT ); Thu, 13 Mar 2008 09:04:55 +0000 Received: from uucp (helo=solo.franken.de) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1JZjMs-000321-00; Thu, 13 Mar 2008 10:04:54 +0100 Received: by solo.franken.de (Postfix, from userid 1000) id E0416DE5B3; Thu, 13 Mar 2008 09:45:26 +0100 (CET) Date: Thu, 13 Mar 2008 09:45:26 +0100 To: Matteo Croce Cc: linux-mips@linux-mips.org, Florian Fainelli , Felix Fietkau , Nicolas Thill , linux-serial@vger.kernel.org, Andrew Morton Subject: Re: [PATCH][MIPS][5/6]: AR7: serial hack Message-ID: <20080313084526.GA6012@alpha.franken.de> References: <200803120221.25044.technoboy85@gmail.com> <200803120230.06420.technoboy85@gmail.com> <20080312093145.GA6270@alpha.franken.de> <200803130138.55582.technoboy85@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803130138.55582.technoboy85@gmail.com> User-Agent: Mutt/1.5.13 (2006-08-11) From: tsbogend@alpha.franken.de (Thomas Bogendoerfer) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 18388 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: tsbogend@alpha.franken.de Precedence: bulk X-list: linux-mips On Thu, Mar 13, 2008 at 01:38:55AM +0100, Matteo Croce wrote: > Il Wednesday 12 March 2008 10:31:46 Thomas Bogendoerfer ha scritto: > > > diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h > > > index 289942f..869b6df 100644 > > > --- a/include/linux/serial_core.h > > > +++ b/include/linux/serial_core.h > > > @@ -40,6 +40,7 @@ > > > #define PORT_NS16550A 14 > > > #define PORT_XSCALE 15 > > > #define PORT_RM9000 16 /* PMC-Sierra RM9xxx internal UART */ > > > +#define PORT_AR7 16 > > > > this doesn't look correct. > > > > Thomas. > > > > Isn't it 16? PORT_RM9000 is 16, how could PORT_AR7 be 16 as well ? And the 16 for PORT_RM9000 is correct in my counting. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ]