From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 18 Mar 2008 13:30:31 +0000 (GMT) Received: from elvis.franken.de ([193.175.24.41]:6289 "EHLO elvis.franken.de") by ftp.linux-mips.org with ESMTP id S28639346AbYCRNa2 (ORCPT ); Tue, 18 Mar 2008 13:30:28 +0000 Received: from uucp (helo=solo.franken.de) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1Jbbta-0007vs-00; Tue, 18 Mar 2008 14:30:26 +0100 Received: by solo.franken.de (Postfix, from userid 1000) id 7294EC2783; Tue, 18 Mar 2008 14:30:15 +0100 (CET) Date: Tue, 18 Mar 2008 14:30:15 +0100 To: Matteo Croce Cc: linux-mips@linux-mips.org, Florian Fainelli , Felix Fietkau , Nicolas Thill , linux-serial@vger.kernel.org, Andrew Morton Subject: Re: [PATCH][MIPS][5/6]: AR7: serial hack Message-ID: <20080318133015.GA7239@alpha.franken.de> References: <200803120221.25044.technoboy85@gmail.com> <200803141646.09645.technoboy85@gmail.com> <20080315104009.GA6533@alpha.franken.de> <200803161645.06364.technoboy85@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803161645.06364.technoboy85@gmail.com> User-Agent: Mutt/1.5.13 (2006-08-11) From: tsbogend@alpha.franken.de (Thomas Bogendoerfer) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 18427 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: tsbogend@alpha.franken.de Precedence: bulk X-list: linux-mips On Sun, Mar 16, 2008 at 04:45:06PM +0100, Matteo Croce wrote: > Il Saturday 15 March 2008 11:40:09 Thomas Bogendoerfer ha scritto: > > On Fri, Mar 14, 2008 at 04:46:09PM +0100, Matteo Croce wrote: > > > This is a bit better > > > > is it possible to try without the serial changes first ? > > > > Use > > > > uart_port[0].type = PORT_16550A; > > > > in arch/mips/ar7/platform.c. > > > > Does it work ? > > > > Tried I get teh usual broken serial output: I just checked the latest AR7/UR8 source, I have, and they don't need special hacks. This is a 2.6.10 based tree. At that time there was no serial8250_console_putchar(), console output was done via serial8250_console_write() without any helper. Before writing to the UART_TX, wait_for_xmitr() is called. And this wait_for_xmitr() does check for BOTH_EMPTY. Is there a good reason, why we don't check for BOTH_EMPTY in serial8250_console_putchar() ? To match the 2.6.10 behaviour we would need that and this would fix the AR7 case without any special handling. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ]