From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 18 Mar 2008 14:17:06 +0000 (GMT) Received: from [81.2.110.250] ([81.2.110.250]:62629 "EHLO lxorguk.ukuu.org.uk") by ftp.linux-mips.org with ESMTP id S28639539AbYCRORE (ORCPT ); Tue, 18 Mar 2008 14:17:04 +0000 Received: from core (localhost.localdomain [127.0.0.1]) by lxorguk.ukuu.org.uk (8.14.2/8.14.2) with ESMTP id m2IE1YwO016315; Tue, 18 Mar 2008 14:01:34 GMT Date: Tue, 18 Mar 2008 14:01:33 +0000 From: Alan Cox To: tsbogend@alpha.franken.de (Thomas Bogendoerfer) Cc: Matteo Croce , linux-mips@linux-mips.org, Florian Fainelli , Felix Fietkau , Nicolas Thill , linux-serial@vger.kernel.org, Andrew Morton Subject: Re: [PATCH][MIPS][5/6]: AR7: serial hack Message-ID: <20080318140133.3d41fd87@core> In-Reply-To: <20080318133015.GA7239@alpha.franken.de> References: <200803120221.25044.technoboy85@gmail.com> <200803141646.09645.technoboy85@gmail.com> <20080315104009.GA6533@alpha.franken.de> <200803161645.06364.technoboy85@gmail.com> <20080318133015.GA7239@alpha.franken.de> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 18430 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: alan@lxorguk.ukuu.org.uk Precedence: bulk X-list: linux-mips > Is there a good reason, why we don't check for BOTH_EMPTY in > serial8250_console_putchar() ? To match the 2.6.10 behaviour we A very good one - we have at least 1 byte of FIFO and the serial-ethernet magic console devices also use that fifo emptying entirely to deduce when to send a new packet. > would need that and this would fix the AR7 case without any > special handling. If the AR7 is an 8250 why does it need special handling? and indeed why does serial work on it except for console - or does that fail too. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [81.2.110.250] ([81.2.110.250]:62629 "EHLO lxorguk.ukuu.org.uk") by ftp.linux-mips.org with ESMTP id S28639539AbYCRORE (ORCPT ); Tue, 18 Mar 2008 14:17:04 +0000 Date: Tue, 18 Mar 2008 14:01:33 +0000 From: Alan Cox Subject: Re: [PATCH][MIPS][5/6]: AR7: serial hack Message-ID: <20080318140133.3d41fd87@core> In-Reply-To: <20080318133015.GA7239@alpha.franken.de> References: <200803120221.25044.technoboy85@gmail.com> <200803141646.09645.technoboy85@gmail.com> <20080315104009.GA6533@alpha.franken.de> <200803161645.06364.technoboy85@gmail.com> <20080318133015.GA7239@alpha.franken.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: Thomas Bogendoerfer Cc: Matteo Croce , linux-mips@linux-mips.org, Florian Fainelli , Felix Fietkau , Nicolas Thill , linux-serial@vger.kernel.org, Andrew Morton Message-ID: <20080318140133.UQTVI2KbzLl7DeyxT5LEnZBMc1RIa2yN5ZPGTtI70pc@z> > Is there a good reason, why we don't check for BOTH_EMPTY in > serial8250_console_putchar() ? To match the 2.6.10 behaviour we A very good one - we have at least 1 byte of FIFO and the serial-ethernet magic console devices also use that fifo emptying entirely to deduce when to send a new packet. > would need that and this would fix the AR7 case without any > special handling. If the AR7 is an 8250 why does it need special handling? and indeed why does serial work on it except for console - or does that fail too.