From: Ralf Baechle <ralf@linux-mips.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] [MIPS] Fix order of BRK_BUG in case
Date: Sun, 20 Apr 2008 12:24:17 +0100 [thread overview]
Message-ID: <20080420112417.GA21078@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0804192310460.20623@wrl-59.cs.helsinki.fi>
On Sat, Apr 19, 2008 at 11:16:36PM +0300, Ilpo Järvinen wrote:
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 984c0d0..4dfcd61 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -694,7 +694,7 @@ asmlinkage void do_bp(struct pt_regs *regs)
> info.si_addr = (void __user *) regs->cp0_epc;
> force_sig_info(SIGFPE, &info, current);
> break;
> - case BRK_BUG:
> + case BRK_BUG << 10:
> die("Kernel bug detected", regs);
^^^
Now what will be happening if with your patch applied a "break BRK_BUG"
instruction is executed in userspace?
Ralf
next prev parent reply other threads:[~2008-04-20 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 20:16 [PATCH] [MIPS] Fix order of BRK_BUG in case Ilpo Järvinen
2008-04-20 11:24 ` Ralf Baechle [this message]
2008-04-20 18:38 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080420112417.GA21078@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox