From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: Breakage in arch/mips/kernel/traps.c for 64bit
Date: Mon, 5 May 2008 00:08:04 +0200 [thread overview]
Message-ID: <20080504220804.GA13442@alpha.franken.de> (raw)
In-Reply-To: <20080504.223944.41198532.anemo@mba.ocn.ne.jp>
On Sun, May 04, 2008 at 10:39:44PM +0900, Atsushi Nemoto wrote:
> > + unsigned long __user *sp = (unsigned long __user *)(reg29 & ~3);
> ...
> > + while (!kstack_end(sp)) {
> > + if (__get_user(addr, sp++)) {
>
> This will leads a sparse warning since an argument for kstack_end is 'void *'.
>
> while (!kstack_end((void *)(unsigned long)sp)) {
>
> will make this part sparse-free, though it seems a bit ugly.
hmm, would leaving sp as unsigned long * and casting it for __get_user()
make sparse happy ?
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2008-05-04 22:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 16:33 Breakage in arch/mips/kernel/traps.c for 64bit Thomas Bogendoerfer
2008-05-01 21:01 ` Maciej W. Rozycki
2008-05-02 10:11 ` Ralf Baechle
2008-05-03 16:16 ` Atsushi Nemoto
2008-05-03 17:39 ` Ralf Baechle
2008-05-03 19:57 ` Maciej W. Rozycki
2008-05-03 22:48 ` Thomas Bogendoerfer
2008-05-04 13:39 ` Atsushi Nemoto
2008-05-04 22:08 ` Thomas Bogendoerfer [this message]
2008-05-05 14:58 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080504220804.GA13442@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox