From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sat, 10 May 2008 07:54:08 +0100 (BST) Received: from zone0.gcu-squad.org ([212.85.147.21]:24464 "EHLO services.gcu-squad.org") by ftp.linux-mips.org with ESMTP id S20022375AbYEJGyE (ORCPT ); Sat, 10 May 2008 07:54:04 +0100 Received: from jdelvare.pck.nerim.net ([62.212.121.182] helo=hyperion.delvare) by services.gcu-squad.org (GCU Mailer Daemon) with esmtpsa id 1JujuC-0002lE-Ak (TLSv1:AES256-SHA:256) (envelope-from ) ; Sat, 10 May 2008 09:54:08 +0200 Date: Sat, 10 May 2008 08:53:40 +0200 From: Jean Delvare To: "Maciej W. Rozycki" Cc: David Brownell , linux-mips@linux-mips.org, mgreer@mvista.com, rtc-linux@googlegroups.com, Atsushi Nemoto , linux-kernel@vger.kernel.org, i2c@lm-sensors.org, ab@mycable.de, Alessandro Zummo Subject: Re: [i2c] [RFC][PATCH 4/4] RTC: SMBus support for the M41T80, Message-ID: <20080510085340.29c26aef@hyperion.delvare> In-Reply-To: References: <200805070120.03821.david-b@pacbell.net> <200805071625.20430.david-b@pacbell.net> <20080509100841.151eabcd@hyperion.delvare> <20080509232146.18638986@hyperion.delvare> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.10.6; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 19190 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: khali@linux-fr.org Precedence: bulk X-list: linux-mips On Sat, 10 May 2008 03:21:35 +0100 (BST), Maciej W. Rozycki wrote: > > This was an option when the functions where introduced 9 years ago. > > But now that it was done, renaming them would cause even more > > confusion, I think. I would be fine with adding comments in i2c-core.c > > or improving Documentation/i2c/smbus-protocol to make it more obious, > > though. > > > > On a related note, you will notice that the other i2c_smbus_* functions > > do not follow the naming of SMBus transactions. Again that's something > > I regret but I feel that changing the names now would cause a lot of > > confusion amongst developers, so I'm not doing it. > > It may not be worth the effort, but if done in bulk for all the users in > the tree, there should be no problem with that. I am fairly sure there > were changes of this kind from time to time, with occasional screams heard > in response from some dark corners, but no big pain. We obviously > explicitly disregard out-of-tree users and for occasional contributors > asking: "Where the * has this function gone?" there is the Documentation/ > tree to provide a greppable reference, so generally not a big deal. It's not that easy. There are some drivers which are both in-tree and out-of-tree, for which such a change means adding ifdefs. And there is i2c-dev.h (the user-space one) which has similar functions, if we rename only the kernel variants, there will be some confusion. But if we rename also the user-space variants, then it's up to 2.4 kernel users to have different names for kernel-space and user-space functions. All in all I'd say it is not worth the effort. There are many other tasks where our time will be better used. > > Just one patch should be enough, if I agree with all the changes. You > > might make a separate patch with the things I may not agree with, so > > that you don't have to cherry-revert them if I indeed don't agree, and > > we just merge them if I do agree. > > Hmm, technically you do not seem to be responsible to accept changes > under drivers/rtc/, so I will split them anyway for others to decide. Huu, sorry, for some reason I thought that we were still speaking about i2c-sibyte. Of course I don't have my say about what happens in drivers/rtc. -- Jean Delvare