Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] IP27: misc fixes
Date: Sat, 24 May 2008 13:13:24 +0100	[thread overview]
Message-ID: <20080524121324.GC20822@linux-mips.org> (raw)
In-Reply-To: <20080417200742.9914FC2BFD@solo.franken.de>

On Thu, Apr 17, 2008 at 10:07:42PM +0200, Thomas Bogendoerfer wrote:

> @@ -100,6 +103,13 @@ int __cpuinit bridge_probe(nasid_t nasid, int widget_id, int masterwid)
>  	 */
>  	bridge->b_wid_control |= BRIDGE_CTRL_IO_SWAP |
>  	                         BRIDGE_CTRL_MEM_SWAP;
> +#ifdef CONFIG_PAGE_SIZE_4KB
> +	bridge->b_wid_control &= ~BRIDGE_CTRL_PAGE_SIZE;
> +#elif defined(CONFIG_PAGE_SIZE_16KB)
> +	bridge->b_wid_control |= BRIDGE_CTRL_PAGE_SIZE;
> +#else
> +#error Fixme for page size other than 4kB and 16kB
> +#endif

This blows up with 64k pages or larger (if anybody is mad enough ...)  The
reason for this setting is so the BRIDGE ASIC knows about the pagesize
and can avoid prefetching over a page boundary.  That is a too small value
is always safe.  I applied your patch with this small fix on top.

Thanks,

  Ralf

      reply	other threads:[~2008-05-24 12:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 20:07 [PATCH] IP27: misc fixes Thomas Bogendoerfer
2008-05-24 12:13 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080524121324.GC20822@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox