From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 24 Jun 2008 06:18:47 +0100 (BST) Received: from colo.lackof.org ([198.49.126.79]:22946 "EHLO colo.lackof.org") by ftp.linux-mips.org with ESMTP id S20022250AbYFXFSp (ORCPT ); Tue, 24 Jun 2008 06:18:45 +0100 Received: from localhost (localhost [127.0.0.1]) by colo.lackof.org (Postfix) with ESMTP id 7EDF7300037; Mon, 23 Jun 2008 23:18:36 -0600 (MDT) Received: from colo.lackof.org ([127.0.0.1]) by localhost (colo.lackof.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 19451-10; Mon, 23 Jun 2008 23:18:26 -0600 (MDT) Received: by colo.lackof.org (Postfix, from userid 27253) id 1DFC4300035; Mon, 23 Jun 2008 23:18:26 -0600 (MDT) Date: Mon, 23 Jun 2008 23:18:26 -0600 From: Grant Grundler To: Adrian Bunk Cc: Roland McGrath , linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk, cooloney@kernel.org, dev-etrax@axis.com, dhowells@redhat.com, gerg@uclinux.org, yasutake.koichi@jp.panasonic.com, linux-parisc@vger.kernel.org, paulus@samba.org, linuxppc-dev@ozlabs.org, linux-sh@vger.kernel.org, chris@zankel.net, linux-mips@linux-mips.org, ysato@users.sourceforge.jp, Andrew Morton Subject: Re: [2.6 patch] asm/ptrace.h userspace headers cleanup Message-ID: <20080624051826.GC19434@colo.lackof.org> References: <20080623174809.GE4756@cs181140183.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080623174809.GE4756@cs181140183.pp.htv.fi> X-Home-Page: http://www.parisc-linux.org/ User-Agent: Mutt/1.5.16 (2007-06-11) X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at lackof.org Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 19605 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: grundler@parisc-linux.org Precedence: bulk X-list: linux-mips On Mon, Jun 23, 2008 at 08:48:09PM +0300, Adrian Bunk wrote: > This patch contains the following cleanups for the asm/ptrace.h > userspace headers: > - include/asm-generic/Kbuild.asm already lists ptrace.h, remove > the superfluous listings in the Kbuild files of the following > architectures: > - cris > - frv > - powerpc > - x86 > - don't expose function prototypes and macros to userspace: > - arm > - blackfin > - cris > - mn10300 > - parisc ... > diff --git a/include/asm-parisc/ptrace.h b/include/asm-parisc/ptrace.h > index 93f990e..3e94c5d 100644 > --- a/include/asm-parisc/ptrace.h > +++ b/include/asm-parisc/ptrace.h > @@ -33,7 +33,6 @@ struct pt_regs { > unsigned long ipsw; /* CR22 */ > }; > > -#define task_regs(task) ((struct pt_regs *) ((char *)(task) + TASK_REGS)) > /* > * The numbers chosen here are somewhat arbitrary but absolutely MUST > * not overlap with any of the number assigned in . > @@ -43,8 +42,11 @@ struct pt_regs { > * since we have taken branch traps too) > */ > #define PTRACE_SINGLEBLOCK 12 /* resume execution until next branch */ > + > #ifdef __KERNEL__ > > +#define task_regs(task) ((struct pt_regs *) ((char *)(task) + TASK_REGS)) > + > /* XXX should we use iaoq[1] or iaoq[0] ? */ > #define user_mode(regs) (((regs)->iaoq[0] & 3) ? 1 : 0) > #define user_space(regs) (((regs)->iasq[1] != 0) ? 1 : 0) Looks fine to me. Acked-by: Grant Grundler