From: Ralf Baechle <ralf@linux-mips.org>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 2/5] [MIPS] Namespace clean-up in arch/mips/pci/pci.c
Date: Thu, 3 Jul 2008 16:22:17 +0100 [thread overview]
Message-ID: <20080703152217.GA24232@linux-mips.org> (raw)
In-Reply-To: <1213773503-23536-3-git-send-email-dmitri.vorobiev@movial.fi>
On Wed, Jun 18, 2008 at 10:18:20AM +0300, Dmitri Vorobiev wrote:
> The following symbols
>
> hose_head
> hose_tail
>
> are needlessly defined global in arch/mips/pci/pci.c, and
> this patch makes them static.
>
> The variable pci_isa_hose is not used, and is removed by
> this patch.
>
> Spotted by namespacecheck. Tested by booting a Malta 4Kc
> board up to the shell prompt.
>
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Queued for 2.6.27. Thanks,
Ralf
next prev parent reply other threads:[~2008-07-03 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 7:18 [PATCH 0/5] [MIPS] Another round of nitpicking Dmitri Vorobiev
2008-06-18 7:18 ` [PATCH 1/5] [MIPS] 8253: make the pit_clockevent variable static Dmitri Vorobiev
2008-07-03 15:21 ` Ralf Baechle
2008-06-18 7:18 ` [PATCH 2/5] [MIPS] Namespace clean-up in arch/mips/pci/pci.c Dmitri Vorobiev
2008-07-03 15:22 ` Ralf Baechle [this message]
2008-06-18 7:18 ` [PATCH 3/5] [MIPS] A few cleanups in malta_int.c Dmitri Vorobiev
2008-07-03 15:22 ` Ralf Baechle
2008-06-18 7:18 ` [PATCH 4/5] [MIPS] Make gcmp_probe() static Dmitri Vorobiev
2008-07-03 15:23 ` Ralf Baechle
2008-06-18 7:18 ` [PATCH 5/5] [MIPS] Add an appropriate header into display.c Dmitri Vorobiev
2008-07-03 15:23 ` Ralf Baechle
2008-07-03 15:28 ` Dmitri Vorobiev
2008-06-30 7:09 ` [PATCH 0/5] [MIPS] Another round of nitpicking Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703152217.GA24232@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@movial.fi \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox