From: David Brownell <david-b@pacbell.net>
To: Kevin Hickey <khickey@rmicorp.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
linux-usb@vger.kernel.org, mano@roarinelk.homelinux.net
Subject: Re: [PATCH] Au1200 USB Device Controller and device-only OTG
Date: Mon, 15 Sep 2008 12:16:01 -0700 [thread overview]
Message-ID: <200809151216.02148.david-b@pacbell.net> (raw)
In-Reply-To: <1221155967-25502-1-git-send-email-khickey@rmicorp.com>
On Thursday 11 September 2008, Kevin Hickey wrote:
> basic device-only OTG (On-The-Go) support
That does't look like it's done right. For starters, it abuses
Kconfig to handle a board-specific config option. Put that data
in platform_data instead ...
Second, it breaks some previously-working code.
Third, it misbehaves even on an x86 config. Needs something like
the appended patch.
- Dave
--- g26.orig/drivers/usb/gadget/Kconfig 2008-09-15 12:10:22.000000000 -0700
+++ g26/drivers/usb/gadget/Kconfig 2008-09-15 12:10:06.000000000 -0700
@@ -490,7 +490,7 @@ config USB_GADGET_DUALSPEED
config USB_PORT_AU1200OTG
boolean "AU1200 USB portmux control (On-The-Go support)"
- depends on USB_GADGET_AU1200 || USB_EHCI_HCD || USB_OHCI_HCD
+ depends on USB_GADGET_AU1200 && (USB_EHCI_HCD || USB_OHCI_HCD)
default n
help
The AU1200 and Au1200 USB device port can be used as either a host
next prev parent reply other threads:[~2008-09-15 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 17:59 [PATCH] Au1200 USB Device Controller and device-only OTG Kevin Hickey
2008-09-15 19:16 ` David Brownell [this message]
2008-09-15 19:26 ` Kevin Hickey
2008-09-15 19:26 ` Kevin Hickey
2008-09-16 6:53 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809151216.02148.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=khickey@rmicorp.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=mano@roarinelk.homelinux.net \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox