From: Jeff Garzik <jgarzik@redhat.com>
To: Weiwei Wang <weiwei.wang@windriver.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable
Date: Wed, 17 Sep 2008 07:40:51 -0400 [thread overview]
Message-ID: <20080917114051.GA30734@shell.devel.redhat.com> (raw)
In-Reply-To: <6781da3918e3c34d23e5f7e9cf777ab463a17d5e.1221613284.git.weiwei.wang@windriver.com>
On Wed, Sep 17, 2008 at 10:25:37AM +0800, Weiwei Wang wrote:
> Netpoll will call the interrupt handler with interrupts
> disabled when using kgdboe, so spin_lock_irqsave() should
> be used instead of spin_lock_irq() to prevent interrupts
> from being incorrectly enabled.
>
> Signed-off-by: Weiwei Wang <weiwei.wang@windriver.com>
> ---
> drivers/net/sb1250-mac.c | 12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
Please send to jeff@garzik.org or jgarzik@pobox.com.
Jeff
next prev parent reply other threads:[~2008-09-17 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 2:25 [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable Weiwei Wang
2008-09-17 11:40 ` Jeff Garzik [this message]
2008-09-20 20:18 ` Ralf Baechle
2008-09-25 19:33 ` Jeff Garzik
2008-09-25 23:49 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917114051.GA30734@shell.devel.redhat.com \
--to=jgarzik@redhat.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=weiwei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox