From: Ralf Baechle <ralf@linux-mips.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>,
linux-mips@linux-mips.org, Michael Buesch <mb@bu3sch.de>
Subject: Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code
Date: Fri, 26 Sep 2008 16:42:34 +0100 [thread overview]
Message-ID: <20080926154233.GA3086@linux-mips.org> (raw)
In-Reply-To: <48DABBBE.7060201@ru.mvista.com>
On Thu, Sep 25, 2008 at 02:14:22AM +0400, Sergei Shtylyov wrote:
>> + res = ssb_pcibios_map_irq(dev, slot, pin);
>> + if (res < 0) {
>> + printk(KERN_ALERT "PCI: Failed to map IRQ of device %s\n",
>> + dev->dev.bus_id);
>> + return 0;
>> + }
>> + /* IRQ-0 and IRQ-1 are software interrupts. */
>> + WARN_ON((res == 0) || (res == 1));
>>
>
> Unneeded ()...
My rule of thumb for the use of parenthesis is that the reader of a piece
of code should not have to know much about operator precendence, so the
occasional avoidable parenthesis if it serves readability.
Ralf
next prev parent reply other threads:[~2008-09-26 15:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 19:18 [PATCH 0/6] BCM47xx patches Aurelien Jarno
2008-09-24 19:19 ` [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code Aurelien Jarno
2008-09-24 21:17 ` Michael Buesch
2008-09-24 22:14 ` Sergei Shtylyov
2008-09-24 22:31 ` Michael Buesch
2008-09-25 0:14 ` John W. Linville
2008-09-25 9:54 ` Sergei Shtylyov
2008-09-25 0:18 ` John W. Linville
2008-09-25 0:18 ` John W. Linville
2008-09-25 10:05 ` Sergei Shtylyov
2008-09-25 12:32 ` Aurelien Jarno
2008-09-25 14:39 ` Sergei Shtylyov
2008-09-25 20:59 ` Michael Buesch
2008-09-25 17:24 ` John W. Linville
2008-09-25 21:00 ` Michael Buesch
2008-09-26 15:42 ` Ralf Baechle [this message]
2008-09-26 18:23 ` [PATCH 1/6 v2] " Aurelien Jarno
2008-09-27 14:06 ` [PATCH 1/6 v3] " Aurelien Jarno
2008-09-27 14:35 ` Ralf Baechle
2008-09-24 19:20 ` [PATCH 2/6] [MIPS] WGT634U: Add machine detection message Aurelien Jarno
2008-09-24 19:21 ` [PATCH 3/6] [MIPS] Remove references to BCM947XX Aurelien Jarno
2008-09-24 19:22 ` [PATCH 4/6] [MIPS] BCM47xx: Use the new SSB GPIO API Aurelien Jarno
2008-09-24 19:23 ` [PATCH 5/6] [MIPS] Add WGT634U reset button support Aurelien Jarno
2008-09-24 19:23 ` [PATCH 6/6] [MIPS] Scan PCI busses when they are registered Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926154233.GA3086@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=aurelien@aurel32.net \
--cc=linux-mips@linux-mips.org \
--cc=mb@bu3sch.de \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox