From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-mips@linux-mips.org, "Paoletti,
Tomaso" <Tomaso.Paoletti@caviumnetworks.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] Don't unmap the memory for dma_sync*.
Date: Sat, 18 Oct 2008 12:02:11 +0100 [thread overview]
Message-ID: <20081018110211.GA17322@linux-mips.org> (raw)
In-Reply-To: <48F93275.8010305@caviumnetworks.com>
On Fri, Oct 17, 2008 at 05:48:53PM -0700, David Daney wrote:
> Don't unmap the memory for dma_sync*.
>
> This must have been typo, it cannot have been correct.
Interesting ...
We were getting away with this for so long only because the only platform
(Jazz) with a non-empty plat_unmap_dma_mem() doesn't call
dma_sync_sg_for_cpu() and dma_sync_sg_for_device() from its commonly used
drivers.
Ralf
prev parent reply other threads:[~2008-10-18 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 0:48 [PATCH] Don't unmap the memory for dma_sync* David Daney
2008-10-18 11:02 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081018110211.GA17322@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Tomaso.Paoletti@caviumnetworks.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox