Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Zhang Le <r0bertz@gentoo.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] defined a macro for lemote 2e box IO base
Date: Fri, 24 Oct 2008 15:27:46 +0800	[thread overview]
Message-ID: <20081024072745.GA14652@adriano.hkcable.com.hk> (raw)
In-Reply-To: <20081022202812.GB10625@linux-mips.org>

On 21:28 Wed 22 Oct     , Ralf Baechle wrote:
> On Thu, Oct 23, 2008 at 12:48:58AM +0000, Zhang Le wrote:
> 
> > +#ifdef CONFIG_64BIT
> > +#define LEMOTE_IO_PORT_BASE 0xffffffffbfd00000
> > +#else
> > +#define LEMOTE_IO_PORT_BASE 0xbfd00000
> > +#endif
> 
> This sort of #ifdefery is one of the reasons why it's better to define
> physical addresses of devices, not virtual addresses in header files.

Thanks for the comment.
I have checked how other platforms handle this problem.
Many have used CKSEG1ADDR.
So I have posted another set of patches here:
http://www.linux-mips.org/archives/linux-mips/2008-10/msg00189.html
http://www.linux-mips.org/archives/linux-mips/2008-10/msg00190.html

Is it OK?

Zhang, Le

  reply	other threads:[~2008-10-24  7:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23  0:48 [PATCH] defined a macro for lemote 2e box IO base Zhang Le
2008-10-22 18:55 ` Thiemo Seufer
2008-10-22 20:28 ` Ralf Baechle
2008-10-24  7:27   ` Zhang Le [this message]
2008-10-24 20:24     ` Maciej W. Rozycki
2008-10-24 20:34       ` Ralf Baechle
2008-10-25  7:31       ` Zhang Le
2008-10-23  0:48 ` [PATCH] added io_map_base to pci_controller on Lemote 2e box Zhang Le
2008-10-22 17:17   ` Zhang Le

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081024072745.GA14652@adriano.hkcable.com.hk \
    --to=r0bertz@gentoo.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox