From: Ralf Baechle <ralf@linux-mips.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: akpm@linux-foundation.org, linux-mips@linux-mips.org,
alessandro.zummo@towertech.it, tsbogend@alpha.franken.de
Subject: Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked
Date: Thu, 30 Oct 2008 12:35:21 +0000 [thread overview]
Message-ID: <20081030123521.GB12719@linux-mips.org> (raw)
In-Reply-To: <4909963E.6060707@ru.mvista.com>
On Thu, Oct 30, 2008 at 02:10:54PM +0300, Sergei Shtylyov wrote:
> From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Date: Thu, 30 Oct 2008 14:10:54 +0300
> To: akpm@linux-foundation.org
> Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
> alessandro.zummo@towertech.it, tsbogend@alpha.franken.de
> Subject: Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> Hello.
>
> akpm@linux-foundation.org wrote:
>
>> From: Andrew Morton <akpm@linux-foundation.org>
>>
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
>> drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
>> drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
>> drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
>> drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
>> drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'
>>
>
> Again, on which architecture this happens?
On non-MIPS. <linux/io.h> is required to build the two files in question
but wasn't getting included explicitly. On MIPS we were lucky; io.h
was getting dragged in indirectly through another header so things just
happened to work.
Ralf
prev parent reply other threads:[~2008-10-30 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:21 [patch 2/3] drivers/rtc/rtc-ds1286.c is borked akpm
2008-10-29 23:19 ` Ralf Baechle
2008-10-30 11:10 ` Sergei Shtylyov
2008-10-30 11:33 ` Sergei Shtylyov
2008-10-30 12:35 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030123521.GB12719@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=alessandro.zummo@towertech.it \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox