From: Ralf Baechle <ralf@linux-mips.org>
To: Phil Sutter <n0-1@freewrt.org>
Cc: linux-mips@linux-mips.org, Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] rb532: gpio register offsets are relatives to GPIOBASE
Date: Fri, 31 Oct 2008 14:47:06 +0000 [thread overview]
Message-ID: <20081031144706.GA9149@linux-mips.org> (raw)
In-Reply-To: <1225459469-12279-1-git-send-email-n0-1@freewrt.org>
On Fri, Oct 31, 2008 at 02:24:29PM +0100, Phil Sutter wrote:
> From: Florian Fainelli <florian@openwrt.org>
>
> This patch fixes the wrong use of GPIO register offsets
> in devices.c. To avoid further problems, use gpio_get_value
> to return the NAND status instead of our own expanded code.
>
> Also define the zero offset of the alternate function register to allow
> consistent access.
>
> Signef-off-by: Phil Sutter <n0-1@freewrt.org>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
Thanks, applied - with the SOBs fixed up.
Ralf
prev parent reply other threads:[~2008-11-01 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 10:12 [PATCH] rb532: gpio register offsets are relatives to GPIOBASE Florian Fainelli
2008-10-31 13:24 ` Phil Sutter
2008-10-31 14:47 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031144706.GA9149@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=n0-1@freewrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox