From: Ralf Baechle <ralf@linux-mips.org>
To: Phil Sutter <n0-1@freewrt.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: rb532: add set_type() function to IRQ struct
Date: Thu, 29 Jan 2009 16:39:56 +0000 [thread overview]
Message-ID: <20090129163956.GC1155@linux-mips.org> (raw)
In-Reply-To: <20081128194234.EC0FC386DBBE@mail.ifyouseekate.net>
On Fri, Nov 28, 2008 at 08:45:10PM +0100, Phil Sutter wrote:
> + switch (type) {
> + case IRQ_TYPE_LEVEL_HIGH:
> + rb532_gpio_set_ilevel(1, gpio);
> + break;
> + case IRQ_TYPE_LEVEL_LOW:
> + rb532_gpio_set_ilevel(0, gpio);
> + break;
> + default:
> + return -EINVAL;
> + }
Linux coding style - the case and default labels should have the same
indentation level as the switch statement. I fixed that.
Applied, thanks.
Ralf
next prev parent reply other threads:[~2009-01-29 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200811202002.16178.david-b@pacbell.net>
2008-11-28 19:35 ` MIPS: RB532: Provide functions for gpio configuration Phil Sutter
2008-11-28 19:45 ` [PATCH] MIPS: rb532: add set_type() function to IRQ struct Phil Sutter
2009-01-29 16:39 ` Ralf Baechle [this message]
2008-11-28 19:46 ` [PATCH] MIPS: rb532: auto disable GPIO alternate function Phil Sutter
2009-01-29 16:41 ` Ralf Baechle
2008-11-28 19:46 ` [PATCH] MIPS: rb532: remove useless CF GPIO initialisation Phil Sutter
2009-01-29 16:47 ` Ralf Baechle
2008-11-28 19:46 ` [PATCH] MIPS: rb532: remove unused rb532_gpio_set_func() Phil Sutter
2009-01-22 0:41 ` Phil Sutter
2009-01-22 18:28 ` [PATCH] rb532: update headers Phil Sutter
2009-01-29 18:04 ` Ralf Baechle
2009-01-22 18:32 ` [PATCH] MIPS: rb532: export rb532_gpio_set_func() Phil Sutter
2009-01-29 18:05 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129163956.GC1155@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=n0-1@freewrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox