mips build failure

mips build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

Hi Ralf,

You probably already now about this, but our build (mips ip32_defconfig)
of Linus' tree (commit aefe6475720bd5eb8aacbc881488f3aa65618562 "Merge
branch 'upstream-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev") gets
these errors (we have actually been getting these errors since 2.6.30-rc1):

In file included from arch/mips/include/asm/compat.h:7,
                 from include/linux/compat.h:15,
                 from arch/mips/kernel/asm-offsets.c:12:
include/linux/seccomp.h: In function 'prctl_get_seccomp':
include/linux/seccomp.h:30: error: 'EINVAL' undeclared (first use in this function)
include/linux/seccomp.h:30: error: (Each undeclared identifier is reported only once
include/linux/seccomp.h:30: error: for each function it appears in.)
include/linux/seccomp.h: In function 'prctl_set_seccomp':
include/linux/seccomp.h:35: error: 'EINVAL' undeclared (first use in this function)

Bisected down to commit ac44021fccd8f1f2b267b004f23a2e8d7ef05f7b
"kmemtrace, rcu: don't include unnecessary headers, allow kmemtrace w/
tracepoints".

http://kisskb.ellerman.id.au/kisskb/buildresult/330240/
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: mips build failure

[Wu Zhangjin]

On Sun, 2009-04-19 at 17:24 +1000, Stephen Rothwell wrote:
> Hi Ralf,
> 
> You probably already now about this, but our build (mips ip32_defconfig)
> of Linus' tree (commit aefe6475720bd5eb8aacbc881488f3aa65618562 "Merge
> branch 'upstream-linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev") gets
> these errors (we have actually been getting these errors since 2.6.30-rc1):
> 
> In file included from arch/mips/include/asm/compat.h:7,
>                  from include/linux/compat.h:15,
>                  from arch/mips/kernel/asm-offsets.c:12:
> include/linux/seccomp.h: In function 'prctl_get_seccomp':
> include/linux/seccomp.h:30: error: 'EINVAL' undeclared (first use in this function)
> include/linux/seccomp.h:30: error: (Each undeclared identifier is reported only once
> include/linux/seccomp.h:30: error: for each function it appears in.)
> include/linux/seccomp.h: In function 'prctl_set_seccomp':
> include/linux/seccomp.h:35: error: 'EINVAL' undeclared (first use in this function)
> 

perhaps you can fix it like this:

include/linux/seccomp.h

 22 #else /* CONFIG_SECCOMP */
 23 
 24 +#include <asm-generic/errno-base.h>
 25 
 26 typedef struct { } seccomp_t;

in reality, there is a previous email sent by Ralf for it:

http://lkml.indiana.edu/hypermail/linux/kernel/0904.2/01152.html

> Bisected down to commit ac44021fccd8f1f2b267b004f23a2e8d7ef05f7b
> "kmemtrace, rcu: don't include unnecessary headers, allow kmemtrace w/
> tracepoints".
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/330240/

Re: mips build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi,

On Sun, 19 Apr 2009 15:32:41 +0800 Wu Zhangjin <wuzhangjin@gmail.com> wrote:
>
> in reality, there is a previous email sent by Ralf for it:
> 
> http://lkml.indiana.edu/hypermail/linux/kernel/0904.2/01152.html

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: mips build failure

[Ingo Molnar]

* Wu Zhangjin <wuzhangjin@gmail.com> wrote:

> On Sun, 2009-04-19 at 17:24 +1000, Stephen Rothwell wrote:
> > Hi Ralf,
> > 
> > You probably already now about this, but our build (mips ip32_defconfig)
> > of Linus' tree (commit aefe6475720bd5eb8aacbc881488f3aa65618562 "Merge
> > branch 'upstream-linus' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev") gets
> > these errors (we have actually been getting these errors since 2.6.30-rc1):
> > 
> > In file included from arch/mips/include/asm/compat.h:7,
> >                  from include/linux/compat.h:15,
> >                  from arch/mips/kernel/asm-offsets.c:12:
> > include/linux/seccomp.h: In function 'prctl_get_seccomp':
> > include/linux/seccomp.h:30: error: 'EINVAL' undeclared (first use in this function)
> > include/linux/seccomp.h:30: error: (Each undeclared identifier is reported only once
> > include/linux/seccomp.h:30: error: for each function it appears in.)
> > include/linux/seccomp.h: In function 'prctl_set_seccomp':
> > include/linux/seccomp.h:35: error: 'EINVAL' undeclared (first use in this function)
> > 
> 
> perhaps you can fix it like this:
> 
> include/linux/seccomp.h
> 
>  22 #else /* CONFIG_SECCOMP */
>  23 
>  24 +#include <asm-generic/errno-base.h>
>  25 
>  26 typedef struct { } seccomp_t;
> 
> in reality, there is a previous email sent by Ralf for it:
> 
> http://lkml.indiana.edu/hypermail/linux/kernel/0904.2/01152.html

Yes, that looks like the right kind of fix.

Ralf, will you push that fix upstream, or should i do it?

Thanks,

	Ingo

Re: mips build failure

[Ralf Baechle]

On Sun, Apr 19, 2009 at 10:16:41AM +0200, Ingo Molnar wrote:

> > in reality, there is a previous email sent by Ralf for it:
> > 
> > http://lkml.indiana.edu/hypermail/linux/kernel/0904.2/01152.html
> 
> Yes, that looks like the right kind of fix.
> 
> Ralf, will you push that fix upstream, or should i do it?

Linus is cc'ed on that patch so expect this patch to show up in his tree
right after the weekend.

  Ralf