Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: David VomLehn <dvomlehn@cisco.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 2/3] mips:powertv: Make kernel command line size configurable (resend)
Date: Mon, 11 May 2009 17:29:24 -0400	[thread overview]
Message-ID: <20090511212924.GA25832@windriver.com> (raw)
In-Reply-To: <20090508163400.GA5466@cuplxvomd02.corp.sa.net>

[Re: [PATCH 2/3] mips:powertv: Make kernel command line size configurable (resend)] On 08/05/2009 (Fri 09:34) David VomLehn wrote:

> On Fri, May 08, 2009 at 11:25:35AM -0400, Paul Gortmaker wrote:
> > On Mon, May 4, 2009 at 6:57 PM, David VomLehn <dvomlehn@cisco.com> wrote:
> > > Most platforms can get by perfectly well with the default command line size,
> > > but some platforms need more. This patch allows the command line size to
> > > be configured for those platforms that need it. The default remains 256
> > > characters.
> > 
> > The one thing I see when I look at this patch, is that it lands in the
> > arch/mips/Kconfig -- but is there really anything fundamentally
> > architecture specific about the allowed length of the kernel command
> > line?.  It probably belongs somewhere alongside the setting for
> > LOG_BUF_LEN or similar (and then add the other respective changes
> > to make all arch actually respect the setting.)
> > 
> > Paul.
> > 
> > >
> > > Signed-off-by: David VomLehn <dvomlehn@cisco.com>
> > > ---
> > >  arch/mips/Kconfig             |    7 +++++++
> > >  arch/mips/include/asm/setup.h |    2 +-
> 
> The reason I put this configuration configuration in the architecture-
> specific Kconfig is because COMMAND_LINE_SIZE is defined in the
> architecture-specific file arch/mips/include/asm/setup.h. I strongly
> agree that this really should not be an architecture-specific definition,
> but it's much more complex to get a patch to change COMMAND_LINE_SIZE
> in every architecture. Fixing in the MIPS tree seems like a good
> start.

It shouldn't be much more complex, at least from a purely technical
point of view (i.e assuming no arch maintainers have a problem with it).
Now, if we tried to get all arch to agree on the same default value,
then I agree that might be more complex/interesting.

All the arch use pretty much the same boilerplate, so something like
this untested patch should work.  I thought about hiding it behind
CONFIG_EMBEDDED, but in theory a person could have some big server
blade with a long command line argument too....

Paul.
---------

  reply	other threads:[~2009-05-11 21:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 22:57 [PATCH 2/3] mips:powertv: Make kernel command line size configurable (resend) David VomLehn
2009-05-06 16:35 ` Ralf Baechle
2009-05-06 16:44   ` Jon Fraser
2009-05-06 16:44     ` Jon Fraser
2009-05-06 18:28     ` David VomLehn
2009-05-06 17:13   ` Manuel Lauss
2009-05-06 18:19   ` David VomLehn
2009-05-06 18:24     ` David Daney
2009-05-06 18:27       ` Jon Fraser
2009-05-06 18:29         ` David Daney
2009-05-06 18:33         ` David VomLehn
2009-05-08 15:25 ` Paul Gortmaker
2009-05-08 15:25   ` Paul Gortmaker
2009-05-08 16:34   ` David VomLehn
2009-05-11 21:29     ` Paul Gortmaker [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-05-29 18:30 David VomLehn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090511212924.GA25832@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=dvomlehn@cisco.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox