Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Andrew Randrianasulu <randrik_a@yahoo.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] IP32 power button fix for 2.6.30
Date: Fri, 15 May 2009 10:13:19 +0100	[thread overview]
Message-ID: <20090515091319.GB7706@linux-mips.org> (raw)
In-Reply-To: <273990.30979.qm@web65307.mail.ac2.yahoo.com>

On Thu, May 14, 2009 at 11:29:27AM -0700, Andrew Randrianasulu wrote:

> X-Mailer: YahooMailClassic/5.2.20 YahooMailWebService/0.7.289.1

> I think i run into same sort of problem, as described here:
> 
> http://lkml.org/lkml/2009/4/16/24
> http://lkml.org/lkml/2009/4/14/94
> 
> (in my case it was hang after pressing O2's power button)
> 
> this patch fixes it:
> 
> ----
> 
> diff --git a/arch/mips/sgi-ip32/ip32-reset.c b/arch/mips/sgi-ip32/ip32-reset.c
> index b6cab08..667da93 100644
> --- a/arch/mips/sgi-ip32/ip32-reset.c
> +++ b/arch/mips/sgi-ip32/ip32-reset.c
> @@ -145,7 +145,7 @@ static irqreturn_t ip32_rtc_int(int irq, void *dev_id)
>                         "%s: RTC IRQ without RTC_IRQF\n", __func__);
>         }
>         /* Wait until interrupt goes away */
> -       disable_irq(MACEISA_RTC_IRQ);
> +       disable_irq_nosync(MACEISA_RTC_IRQ);
>         init_timer(&debounce_timer);
>         debounce_timer.function = debounce;
>         debounce_timer.expires = jiffies + 50;

 - no Signed-off-by: line
 - whitespace garbled.  Use a proper mail client such as /bin/mail ;-)

Grumblingly applied,

  Ralf

  reply	other threads:[~2009-05-15  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 18:29 [PATCH] IP32 power button fix for 2.6.30 Andrew Randrianasulu
2009-05-15  9:13 ` Ralf Baechle [this message]
2009-05-15  9:20   ` Dmitri Vorobiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090515091319.GB7706@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=randrik_a@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox