From: Ralf Baechle <ralf@linux-mips.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] rb532: check irq number when handling GPIO interrupts
Date: Fri, 22 May 2009 07:57:26 +0100 [thread overview]
Message-ID: <20090522065726.GB12444@linux-mips.org> (raw)
In-Reply-To: <200905220703.28939.florian@openwrt.org>
On Fri, May 22, 2009 at 07:03:28AM +0200, Florian Fainelli wrote:
> That's actually 14, numbering starting from 0, I should learn how to count.
> Ralf, do you want me to resubmit that one with the proper message /
> descriptions ?
>
> >
> > > rb532_gpio_set_istat(0, irq_nr - GPIO_MAPPED_IRQ_BASE);
> > >
> > > /*
> > > @@ -174,7 +175,7 @@ static int rb532_set_type(unsigned int irq_nr,
> > > unsigned type) int gpio = irq_nr - GPIO_MAPPED_IRQ_BASE;
> > > int group = irq_to_group(irq_nr);
> > >
> > > - if (group != GPIO_MAPPED_IRQ_GROUP)
> > > + if (group != GPIO_MAPPED_IRQ_GROUP || irq_nr > (GROUP4_IRQ_BASE + 13))
> >
> > ... and >= here.
> >
> > > return (type == IRQ_TYPE_LEVEL_HIGH) ? 0 : -EINVAL;
> > >
> > > switch (type) {
Queued for 2.6.31 with the comment fix and the change from > to >=.
Thanks,
Ralf
prev parent reply other threads:[~2009-05-22 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 17:49 [PATCH 2/2] rb532: check irq number when handling GPIO interrupts Florian Fainelli
2009-05-21 18:52 ` Sergei Shtylyov
2009-05-22 5:03 ` Florian Fainelli
2009-05-22 6:57 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090522065726.GB12444@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox