From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sat, 23 May 2009 12:43:16 +0100 (BST) Received: from ey-out-1920.google.com ([74.125.78.149]:45086 "EHLO ey-out-1920.google.com" rhost-flags-OK-OK-OK-OK) by ftp.linux-mips.org with ESMTP id S20022681AbZEWLnJ convert rfc822-to-8bit (ORCPT ); Sat, 23 May 2009 12:43:09 +0100 Received: by ey-out-1920.google.com with SMTP id 13so542033eye.54 for ; Sat, 23 May 2009 04:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version :content-disposition:message-id:content-type :content-transfer-encoding; bh=KaBHfMo3iS9iT6J/3/6IG1mM96zPYP1mtvbjCtw/ls8=; b=Ujr/i+0aSbZ5yS1sUUBo0FOBIauhhWaIxS3AffQL8ZHzlX6qLJVxmNi5KdeyupotXZ 0TAygSzn1Ki0VOFip+6n5l7xLv4214a//exu1EPYEbDgs8pibCGcLH6GvU3waYts+skd /gDxluj43cvLePwzOTC0UgJ4WisaVvdwWBVwU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=C8e9z89/E66W0oav/K0YkR1mZTTE6hd7dF1oKXgciuw6xSJ2pNYSt5wAF+9gHH43IQ FDuDHijzYMroWs4NCx1gNUi/G+z4UlB6EgDbg1B1uvn6Am/HRNatxUnmmsJLersCxt0I lWSL/KB1ZUGVOkz+MXdXl47bTp5bY8KF1IzJM= Received: by 10.210.29.9 with SMTP id c9mr6123762ebc.9.1243078988201; Sat, 23 May 2009 04:43:08 -0700 (PDT) Received: from localhost.localdomain (chello089077051219.chello.pl [89.77.51.219]) by mx.google.com with ESMTPS id 7sm3678335eyg.27.2009.05.23.04.43.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 23 May 2009 04:43:07 -0700 (PDT) From: Bartlomiej Zolnierkiewicz To: yanh@lemote.com Subject: Re: [loongson-PATCH-v1 24/27] fixup for FUJITSU disk Date: Sat, 23 May 2009 13:47:34 +0200 User-Agent: KMail/1.11.3 (Linux/2.6.30-rc6-next-20090518-05332-g0707b5a; KDE/4.2.3; i686; ; ) Cc: wuzhangjin@gmail.com, linux-mips@linux-mips.org, Ralf Baechle , "IDE/ATA development list" , Linux Kernel , "linux-scsi" , Philippe Vachon , Zhang Le , Zhang Fuxin , Arnaud Patard , loongson-dev@googlegroups.com, gnewsense-dev@nongnu.org, Nicholas Mc Guire , Liu Junliang , Erwan Lerale References: <200905222032.55869.bzolnier@gmail.com> <1243062702.8509.7.camel@localhost.localdomain> In-Reply-To: <1243062702.8509.7.camel@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200905231347.34717.bzolnier@gmail.com> Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 22948 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: bzolnier@gmail.com Precedence: bulk X-list: linux-mips On Saturday 23 May 2009 09:11:42 yanh wrote: > 在 2009-05-22五的 20:32 +0200，Bartlomiej Zolnierkiewicz写道： > > On Thursday 21 May 2009 00:12:46 wuzhangjin@gmail.com wrote: > > > From: Wu Zhangjin > > > > > > This is originally from the to-mips branch from > > > http://dev.lemote.com/code/linux_loongson > > > > Sadly, the patch description lacks all the important information. > > > > What is the original problem that this fixup tries to address? > > > > Is it limited to amd74xx controllers? > > In loongson2f yeeloong machines, the ide controller is AMD cs5536, or > say amd74xx, and the hard drives is Fujistu. Then it should use the new & shiny :) native cs5536 IDE host driver instead of legacy support in amd74xx... > While debuging the hard disk suspned and resume, the ide irq can not be > cleared. I guess this is a fake interrupt, hence the clear irq action > can not be finished. AFAICS the only change that the fixup would cause for suspend/resume paths is the one in ide_config_drive_speed() which is called during resume to set transfer mode on the drive: tp_ops->write_devctl(hwif, ATA_NIEN | ATA_DEVCTL_OBS); memset(&tf, 0, sizeof(tf)); tf.feature = SETFEATURES_XFER; tf.nsect = speed; tp_ops->tf_load(drive, &tf, IDE_VALID_FEATURE | IDE_VALID_NSECT); tp_ops->exec_command(hwif, ATA_CMD_SET_FEATURES); ---> if (drive->quirk_list == 2) tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS); ---> error = __ide_wait_stat(drive, drive->ready_stat, ATA_BUSY | ATA_DRQ | ATA_ERR, WAIT_CMD, &stat); Please tell me I if understand the issue correctly: if the above quirk is not executed we end up with spurious IRQs, right? > This patch is to fix this issue. Maybe other controller and drives also > have this issue, but I am not sure. Probably moving it to a generic quirk_drives list later will be useful... Anyway this fixup needs to be ported to / verified with cs5536 first. Thanks. Bart