From: Ralf Baechle <ralf@linux-mips.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>
Subject: Re: [PATCH 05/10] bcm63xx: dev-enet: initialize shared_device_registered to 0
Date: Mon, 1 Jun 2009 15:41:13 +0100 [thread overview]
Message-ID: <20090601144113.GD6604@linux-mips.org> (raw)
In-Reply-To: <200905312028.37498.florian@openwrt.org>
On Sun, May 31, 2009 at 08:28:37PM +0200, Florian Fainelli wrote:
> This patch initialize the shared_device_registered
> variable with 0, actually required for the check
> to be working.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/arch/mips/bcm63xx/dev-enet.c b/arch/mips/bcm63xx/dev-enet.c
> index 51c2e5a..0298973 100644
> --- a/arch/mips/bcm63xx/dev-enet.c
> +++ b/arch/mips/bcm63xx/dev-enet.c
> @@ -28,7 +28,7 @@ static struct platform_device bcm63xx_enet_shared_device = {
> .resource = shared_res,
> };
>
> -static int shared_device_registered;
> +static int shared_device_registered = 0;
This is bogus. The variable defaults to zero. Explicit initialization
however will inflate the .data section. Dropped.
Ralf
prev parent reply other threads:[~2009-06-01 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 18:28 [PATCH 05/10] bcm63xx: dev-enet: initialize shared_device_registered to 0 Florian Fainelli
2009-06-01 14:41 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601144113.GD6604@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox