From: Ralf Baechle <ralf@linux-mips.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>
Subject: Re: [PATCH 07/10] bcm63xx: fix typo when printing CPU frequency
Date: Mon, 1 Jun 2009 15:46:18 +0100 [thread overview]
Message-ID: <20090601144618.GF6604@linux-mips.org> (raw)
In-Reply-To: <200905312029.50326.florian@openwrt.org>
On Sun, May 31, 2009 at 08:29:49PM +0200, Florian Fainelli wrote:
> This patch corrects the comment about the CPU
> frequency which is actually printed in Hz and not MHz.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/arch/mips/bcm63xx/cpu.c b/arch/mips/bcm63xx/cpu.c
> index 0a403dd..410c788 100644
> --- a/arch/mips/bcm63xx/cpu.c
> +++ b/arch/mips/bcm63xx/cpu.c
> @@ -238,7 +238,7 @@ void __init bcm63xx_cpu_init(void)
>
> printk(KERN_INFO "Detected Broadcom 0x%04x CPU revision %02x\n",
> bcm63xx_cpu_id, bcm63xx_cpu_rev);
> - printk(KERN_INFO "CPU frequency is %u MHz\n",
> + printk(KERN_INFO "CPU frequency is %u Hz\n",
While technically ok I would suggest to print the number in MHz. Acuracy
probably doesn't matter so even rounding to whole MHz would be ok.
Want me to apply anyway?
Ralf
next prev parent reply other threads:[~2009-06-01 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 18:29 [PATCH 07/10] bcm63xx: fix typo when printing CPU frequency Florian Fainelli
2009-06-01 14:46 ` Ralf Baechle [this message]
2009-06-01 14:50 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601144618.GF6604@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).