From: Ralf Baechle <ralf@linux-mips.org>
To: Imre Kaloz <kaloz@openwrt.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Honor CONFIG_CMDLINE on SiByte
Date: Tue, 2 Jun 2009 18:59:27 +0100 [thread overview]
Message-ID: <20090602175927.GE32078@linux-mips.org> (raw)
In-Reply-To: <1243945334-5090-1-git-send-email-kaloz@openwrt.org>
On Tue, Jun 02, 2009 at 02:22:14PM +0200, Imre Kaloz wrote:
> The SiByte platform code doesn't honor the CONFIG_CMDLINE kernel
> option. This patch fixes this issue.
>
> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
> ---
> arch/mips/sibyte/common/cfe.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/sibyte/common/cfe.c b/arch/mips/sibyte/common/cfe.c
> index 3de30f7..97e997e 100644
> --- a/arch/mips/sibyte/common/cfe.c
> +++ b/arch/mips/sibyte/common/cfe.c
> @@ -293,7 +293,11 @@ void __init prom_init(void)
> * It's OK for direct boot to not provide a
> * command line
> */
> +#ifdef CONFIG_CMDLINE
> + strlcpy(arcs_cmdline, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> +#else
> strcpy(arcs_cmdline, "root=/dev/ram0 ");
> +#endif
I rather think the strcpy should go instead. Hardwiring an option doesn't
seem a good idea.
Ralf
prev parent reply other threads:[~2009-06-02 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 12:22 [PATCH] Honor CONFIG_CMDLINE on SiByte Imre Kaloz
2009-06-02 17:59 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602175927.GE32078@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=kaloz@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).